<html><head></head><body><div>On Fri, 2017-07-14 at 10:34 -0700, Jason Ekstrand wrote:</div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Jul 14, 2017 at 3:09 AM, Iago Toral <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote type="cite">Patches 1-5 and 7-8 are:<br>
Reviewed-by: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>><br>
<br>
I dropped minor comments to patches 4-5, feel free to ignore them if<br>
you don't consider them relevant though.<br>
<br>
I also dropped a couple of comments on patch 6. It looks good to me in<br>
general but I think this one needs someone more knowledgeable in SPIRV<br>
and variable pointers than me for a proper review, so you might want to<br>
have someone else have a look at this one<font color="#888888">.</font><br></blockquote><div><br></div><div>I think you're as qualified as anyone at this point.<br></div></div></div></div></blockquote><div><br></div><div>Thanks for the clarifications you sent, feel free to add my Rb to patch 6 as well after removing the dead loop in there.</div><div><br></div><div>Iago</div><div><br></div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote type="cite"><span class="HOEnZb"><font color="#888888"><br>
Iago<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Thu, 2017-07-13 at 12:41 -0700, Jason Ekstrand wrote:<br>
> This little series contains the SPIR-V and ANV bits for the new<br>
> VK_KHR_variable_pointers extension and it's prerequisite extension<br>
> VK_KHR_storage_buffer_storage_<wbr>class.<br>
><br>
> Cc: Connor Abbott <<a href="mailto:cwabbott0@gmail.com">cwabbott0@gmail.com</a>><br>
><br>
> Jason Ekstrand (8):<br>
> spirv: Import the latest 1.0.2 header from Khronos<br>
> spirv: Add support for the StorageBuffer storage class<br>
> spirv/nir: Add some useful asserts for type decorations<br>
> nir/spirv: Implement OpPtrAccessChain for buffers<br>
> nir/spirv: Add a helper for pushing SSA values<br>
> nir/spirv: Add support for SPV_KHR_variable_pointers<br>
> anv: Advertise support for VK_KHR_storage_buffer_storage_<wbr>class<br>
> anv: Advertise support for VK_KHR_variable_pointers<br>
><br>
> src/compiler/spirv/nir_spirv.<wbr>h | 1 +<br>
> src/compiler/spirv/spirv.h <wbr> | 41 ++++++++++++++++--<br>
> src/compiler/spirv/spirv_to_<wbr>nir.c | 53 ++++++++++++++++++++---<br>
> src/compiler/spirv/vtn_cfg.c <wbr> | 16 +++----<br>
> src/compiler/spirv/vtn_<wbr>private.h | 39 +++++++++++++++--<br>
> src/compiler/spirv/vtn_<wbr>variables.c | 77<br>
> ++++++++++++++++++++++++++++++<wbr>---<br>
> src/intel/vulkan/anv_device.<wbr>c | 15 +++++++<br>
> src/intel/vulkan/anv_<wbr>entrypoints_gen.py | 2 +<br>
> src/intel/vulkan/anv_<wbr>pipeline.c | 1 +<br>
> 9 files changed, 220 insertions(+), 25 deletions(-)<br>
><br>
</div></div><br></blockquote></div><br></div></div>
</blockquote></body></html>