<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 29, 2017 at 7:45 PM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Allows us to disable array spliting for arrays of arrays without<br>
regressing tests such as:<br>
<br>
ES31-CTS.functional.shaders.<wbr>arrays_of_arrays.return.<wbr>explicit.struct_3x1x3_fragment<br>
---<br>
 src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c b/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c<br>
index e5a12eb..31f7e7a 100644<br>
--- a/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c<br>
+++ b/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c<br>
@@ -441,7 +441,7 @@ static bool<br>
 lower_copies_to_load_store(<wbr>struct deref_node *node,<br>
                            struct lower_variables_state *state)<br>
 {<br>
-   if (!node->copies)<br>
+   if (!node || !node->copies)<br></blockquote><div><br></div><div>If we got a NULL node here, something is wrong.  I think this is just papering over the issue.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
       return true;<br>
<br>
    struct set_entry *copy_entry;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>