<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 18, 2017 at 1:30 PM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tuesday, July 18, 2017 1:46:13 AM PDT Topi Pohjolainen wrote: [snip] > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h b/src/mesa/drivers/dri/i965/intel_blit.h > index 5e4d1f5eb4..90514dc893 100644 > --- a/src/mesa/drivers/dri/i965/intel_blit.h > +++ b/src/mesa/drivers/dri/i965/intel_blit.h > @@ -41,17 +41,32 @@ isl_tiling_to_bufmgr_tiling(enum isl_tiling tiling) > return I915_TILING_NONE; > } > > +static inline enum isl_tiling > +bufmgr_tiling_to_isl_tiling(unsigned tiling) > +{ > + switch (tiling) { > + case I915_TILING_NONE: > + return ISL_TILING_LINEAR; > + case I915_TILING_X: > + return ISL_TILING_X; > + case I915_TILING_Y: > + return ISL_TILING_Y0; > + } > + > + unreachable("Invalid tiling mode"); > +} > + This doesn't appear to be used at this point. If it's used later, great, but I'm not sure why you'd need a converter in this direction? </blockquote></div> </div><div class="gmail_extra">It's used in miptree_create_for_bo Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div></div>