<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 18, 2017 at 4:26 PM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 19/07/17 09:17, Jason Ekstrand wrote:<span class=""><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Jun 29, 2017 at 7:45 PM, Timothy Arceri <<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a> <mailto:<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>><wbr>> wrote:<br>
<br>
    Allows us to disable array spliting for arrays of arrays without<br>
    regressing tests such as:<br>
<br>
    <a href="http://ES31-CTS.functional.shaders.ar">ES31-CTS.functional.shaders.ar</a><wbr>rays_of_arrays.return.explicit<wbr>.struct_3x1x3_fragment<br>
    ---<br>
      src/compiler/nir/nir_lower_var<wbr>s_to_ssa.c | 2 +-<br>
      1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
    diff --git a/src/compiler/nir/nir_lower_v<wbr>ars_to_ssa.c<br>
    b/src/compiler/nir/nir_lower_v<wbr>ars_to_ssa.c<br>
    index e5a12eb..31f7e7a 100644<br>
    --- a/src/compiler/nir/nir_lower_v<wbr>ars_to_ssa.c<br>
    +++ b/src/compiler/nir/nir_lower_v<wbr>ars_to_ssa.c<br>
    @@ -441,7 +441,7 @@ static bool<br>
      lower_copies_to_load_store(str<wbr>uct deref_node *node,<br>
                                 struct lower_variables_state *state)<br>
      {<br>
    -   if (!node->copies)<br>
    +   if (!node || !node->copies)<br>
<br>
<br>
If we got a NULL node here, something is wrong.  I think this is just papering over the issue.<br>
</blockquote>
<br></span>
It's possible this was only an issue before the fix in the following patch. I'll drop this and push to jenkins to see if this can be dropped.<br></blockquote><div><br></div><div>It can't.  I tried.<br><br></div><div>I just sent a patch that fixes the iterator to never pass in NULL.  I'd prefer we replace this patch with that one.  I've verified that it fixes the test mentioned in the commit message.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
            return true;<br>
<br>
         struct set_entry *copy_entry;<br>
    --<br>
    2.9.4<br>
<br>
    ______________________________<wbr>_________________<br>
    mesa-dev mailing list<br></span>
    <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <mailto:<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedes<wbr>ktop.org</a>><br>
    <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
    <<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org<wbr>/mailman/listinfo/mesa-dev</a>><br>
<br>
<br>
</blockquote>
</blockquote></div><br></div></div>