<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 18, 2017 at 11:15 AM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I can believe the fix, but I don't understand why it's necessary.<br>
spirv_info.c includes spriv_info.h in the same manner as before<br>
2dd4e2ec, and, as far as I can understand, spirv_info.c gets built in<br>
the same way as before.  Can someone explain to me why it broke?<br>
...because I don't want to break it again.<span class=""><br></span></blockquote><div><br></div><div>Out-of-tree builds.  In that case, spirv_info.c is in the build directory but spirv_info.h is in the source directory.<br><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
On 07/18/2017 11:03 AM, Eric Engestrom wrote:<br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=101831" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=101831</a><br>
> Signed-off-by: Eric Engestrom <<a href="mailto:eric.engestrom@imgtec.com">eric.engestrom@imgtec.com</a>><br>
> ---<br>
><br>
> Note: Android and SCons probably need a similar fix<br>
> ---<br>
>  src/compiler/<a href="http://Makefile.nir.am" rel="noreferrer" target="_blank">Makefile.nir.am</a> | 3 +++<br>
>  1 file changed, 3 insertions(+)<br>
><br>
> diff --git a/src/compiler/<a href="http://Makefile.nir.am" rel="noreferrer" target="_blank">Makefile.nir.am</a> b/src/compiler/<a href="http://Makefile.nir.am" rel="noreferrer" target="_blank">Makefile.nir.am</a><br>
> index 1533ee536d..002b9fc535 100644<br>
> --- a/src/compiler/<a href="http://Makefile.nir.am" rel="noreferrer" target="_blank">Makefile.nir.am</a><br>
> +++ b/src/compiler/<a href="http://Makefile.nir.am" rel="noreferrer" target="_blank">Makefile.nir.am</a><br>
> @@ -32,6 +32,9 @@ nir_libnir_la_SOURCES =                                     \<br>
>       $(SPIRV_GENERATED_FILES)                        \<br>
>       $(NIR_GENERATED_FILES)<br>
><br>
> +nir_libnir_la_SOURCES = \<br>
> +     -I$(top_builddir)/src/<wbr>compiler/spirv<br>
> +<br>
>  nir/nir_builder_opcodes.h: nir/nir_opcodes.py nir/nir_builder_opcodes_h.py<br>
>       $(MKDIR_GEN)<br>
>       $(PYTHON_GEN) $(srcdir)/nir/nir_builder_<wbr>opcodes_h.py > $@ || ($(RM) $@; false)<br>
><br>
<br>
</span>______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>