<div dir="ltr">I don't really like the lack of isl_ prefix. We could call it isl_tiling_from_i915_tiling(). I don't care all that much though. </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Jul 19, 2017 at 12:48 PM, Topi Pohjolainen <<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Suggested-by: Daniel Stone <<a href="mailto:daniels@collabora.com">daniels@collabora.com</a>> Signed-off-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>> --- src/intel/isl/isl.h | 3 +++ src/intel/isl/isl_drm.c | 17 +++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index d81df31a37..af46b6bf29 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -1516,6 +1516,9 @@ isl_tiling_is_std_y(enum isl_tiling tiling) uint32_t isl_tiling_to_i915_tiling(enum isl_tiling tiling); +enum isl_tiling +i915_tiling_to_isl_tiling(uint32_t tiling); + const struct isl_drm_modifier_info * ATTRIBUTE_CONST isl_drm_modifier_get_info(uint64_t modifier); diff --git a/src/intel/isl/isl_drm.c b/src/intel/isl/isl_drm.c index b7a4997d2d..b8f8e1214e 100644 --- a/src/intel/isl/isl_drm.c +++ b/src/intel/isl/isl_drm.c @@ -54,6 +54,23 @@ isl_tiling_to_i915_tiling(enum isl_tiling tiling) unreachable("Invalid ISL tiling"); } +enum isl_tiling +i915_tiling_to_isl_tiling(uint32_t tiling) +{ + switch (tiling) { + case I915_TILING_NONE: + return ISL_TILING_LINEAR; + + case I915_TILING_X: + return ISL_TILING_X; + + case I915_TILING_Y: + return ISL_TILING_Y0; + } + + unreachable("Invalid i915 tiling"); +} + struct isl_drm_modifier_info modifier_info[] = { { .modifier = DRM_FORMAT_MOD_NONE, -- 2.11.0 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>