<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Jul 21, 2017 at 8:00 AM, Topi Pohjolainen <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>><br>
---<br>
 src/intel/isl/isl.c | 6 ++++--<br>
 1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c<br>
index 7d1356f0ac..4393088409 100644<br>
--- a/src/intel/isl/isl.c<br>
+++ b/src/intel/isl/isl.c<br>
@@ -1316,8 +1316,10 @@ isl_calc_row_pitch(const struct isl_device *dev,<br>
        !pitch_in_range(row_pitch, _3DSTATE_HIER_DEPTH_BUFFER_<wbr>SurfacePitch_bits(dev->info)))<br>
       return false;<br>
<br>
-   if (surf_info->usage & ISL_SURF_USAGE_STENCIL_BIT)<br>
-      isl_finishme("validate row pitch of stencil surfaces");<br>
+   if ((surf_info->usage & ISL_SURF_USAGE_STENCIL_BIT) &&<br>
+       !pitch_in_range(row_pitch,<br>
+                       _3DSTATE_STENCIL_BUFFER_<wbr>SurfacePitch_bits(dev->info)))<br>
+      return false;<br></blockquote><div><br></div><div>I think we want this to be<br><br></div><div>if (surf_info->usage & ISL_SURF_USAGE_STENCIL_BIT) {<br></div><div>   if (surf_info->format == ISL_FORMAT_R8_UINT) {<br>      if (!pitch_in_range(row_pitch, _3DSTATE_STENCIL_BUFFER_<wbr>SurfacePitch_bits(dev->info)))<br></div><div>         return false;<br></div><div>   } else {<br>      if (!pitch_in_range(row_pitch, _3DSTATE_DEPTH_BUFFER_<wbr>SurfacePitch_bits(dev->info)))<br><div>         return false;<br></div>   }<br></div><div>}<br><br></div><div>I'm not sure how gen4 is even working without doing that.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
  done:<br>
    *out_row_pitch = row_pitch;<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.11.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>