<div dir="ltr">Fair enough.<br><br>Although from my tests with x86-64 GCC 6.3 (Fedora 25), it did produce a slightly smaller binary with this patch.<div><br>With that said, I only used whatever the default optimization flags are, and I didn't do a diff on a disasm to see what actually changed.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 24, 2017 at 1:03 PM, Nicolai Hähnle <span dir="ltr"><<a href="mailto:nhaehnle@gmail.com" target="_blank">nhaehnle@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 23.07.2017 18:24, Mystro256 wrote:<br>
> ---<br>
> src/amd/addrlib/core/<wbr>addrobject.cpp | 4 ++--<br>
> 1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/src/amd/addrlib/core/<wbr>addrobject.cpp b/src/amd/addrlib/core/<wbr>addrobject.cpp<br>
> index dcdb1bf..ee2d9a9 100644<br>
> --- a/src/amd/addrlib/core/<wbr>addrobject.cpp<br>
> +++ b/src/amd/addrlib/core/<wbr>addrobject.cpp<br>
> @@ -61,9 +61,9 @@ Object::Object()<br>
> * Constructor for the Object class.<br>
> ******************************<wbr>******************************<wbr>******************************<wbr>**********<br>
> */<br>
> -Object::Object(const Client* pClient)<br>
> +Object::Object(const Client* pClient):<br>
> + m_client (*pClient)<br>
> {<br>
> - m_client = *pClient;<br>
> }<br>
<br>
</span>Thanks, but this is really a matter of taste and coding style. It should<br>
make no difference for the generated code, and I believe addrlib<br>
generally prefers not to use the initializer list, so NAK on this patch.<br>
<br>
Cheers,<br>
Nicolai<br>
<br>
<br>
><br>
> /**<br>
><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Lerne, wie die Welt wirklich ist,<br>
Aber vergiss niemals, wie sie sein sollte.<br>
</font></span></blockquote></div><br></div>