<html><head></head><body>Dully noted, thanks for the heads up.<br><br><div class="gmail_quote">On July 25, 2017 12:50:22 PM EDT, "Marek Olšák" <maraeo@gmail.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi Jeremy,<br /><br />Note that addrlib is imported from our internal repository. Any<br />changes to addrlib in Mesa may make later updates from the internal<br />repository more difficult. It would be preferable to apply changes to<br />the internal addrlib first and Mesa would get them on the next addrlib<br />update.<br /><br />I personally don't bother cleaning up addrlib in Mesa except maybe<br />fixing warnings.<br /><br />Marek<br /><br />On Mon, Jul 24, 2017 at 7:17 PM, Jeremy Newton <alexjnewt@hotmail.com> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Fair enough.<br /><br /> Although from my tests with x86-64 GCC 6.3 (Fedora 25), it did produce a<br /> slightly smaller binary with this patch.<br /><br /> With that said, I only used whatever the default optimization flags are, and<br /> I didn't do a diff on a disasm to see what actually changed.<br /><br /> On Mon, Jul 24, 2017 at 1:03 PM, Nicolai Hähnle <nhaehnle@gmail.com> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><br /> On 23.07.2017 18:24, Mystro256 wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> ---<br /> src/amd/addrlib/core/addrobject.cpp | 4 ++--<br /> 1 file changed, 2 insertions(+), 2 deletions(-)<br /><br /> diff --git a/src/amd/addrlib/core/addrobject.cpp<br /> b/src/amd/addrlib/core/addrobject.cpp<br /> index dcdb1bf..ee2d9a9 100644<br /> --- a/src/amd/addrlib/core/addrobject.cpp<br /> +++ b/src/amd/addrlib/core/addrobject.cpp<br /> @@ -61,9 +61,9 @@ Object::Object()<br /> * Constructor for the Object class.<br /><br /> ****************************************************************************************************<br /> */<br /> -Object::Object(const Client* pClient)<br /> +Object::Object(const Client* pClient):<br /> + m_client (*pClient)<br /> {<br /> - m_client = *pClient;<br /> }<br /></blockquote><br /> Thanks, but this is really a matter of taste and coding style. It should<br /> make no difference for the generated code, and I believe addrlib<br /> generally prefers not to use the initializer list, so NAK on this patch.<br /><br /> Cheers,<br /> Nicolai<br /><br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"><br /> /**</blockquote><br /><br /><br /> --<br /> Lerne, wie die Welt wirklich ist,<br /> Aber vergiss niemals, wie sie sein sollte.<br /></blockquote><br /><br /><br /><hr /><br /> mesa-dev mailing list<br /> mesa-dev@lists.freedesktop.org<br /> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a></blockquote><br /><hr /><br />mesa-dev mailing list<br />mesa-dev@lists.freedesktop.org<br /><a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br /></pre></blockquote></div></body></html>