<div dir="ltr">Thanks for the reviews! I rebased patch number #4, and added platform_wayland support and squashed this patch to form patch #5. Note it seems platform_drm already has the correct path for swrast, since gbm_dri_screen_extensions already has the lookup extension and the dri2_drm_display_vtbl is used regardless whether the driver is hardware or swrast. </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Aug 1, 2017 at 8:55 AM, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 28 July 2017 at 04:48, Gurchetan Singh <<a href="mailto:gurchetansingh@chromium.org">gurchetansingh@chromium.org</a>> wrote: > This will allow the swrast driver to use eglCreateImageKHR, > provided the target is EGL_GL_TEXTURE_2D_KHR or > EGL_GL_RENDERBUFFER_KHR. Note we still have to implement the > create from render buffer path. Thanks for the re-spin Gurchetan! Implementing the renderbuffer path would be great. None of the gallium drivers currently support it ;-) A couple of small suggestions: - 5/6 effectively enables the extensions, thus it should be the last in the series - the drm and wayland platforms could use a patch similar to this, otherwise they'll advertise the extensions but the API will always fail Feel free to squash with this patch, keep separate or simply force disable the extensions on said platforms. With that the series is Reviewed-by: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>> -Emil </blockquote></div> </div>