<div dir="ltr"><div><div>I was a bit confused by this at first but I think I understand it. Just to clarify, this isn't actually dropping support for any version of expat, it's just dropping support for automatic detection without a pkg-config file, which coincidentally started shipping in 2.1.0. But it's not like there's an actual API change from that version that is now being required. So if you did happen to have an older expat version that you manually created a .pc file for, then things should build and work just fine, barring of course any expat bugs from untested older versions. Do I have that right?<br><br></div>My motivator for this line of inquiry is this really: Is there still a way to "convince" Mesa to use a given expat library if you don't have a .pc file for it, even if it's a long irritating process of manually specifying include and link info in some way through stuffing flags into extra --with-expat= options or EXPAT_CFLAGS env vars or anything like that?<br clear="all"></div><br><div><div><div><div><div class="gmail_extra"><br><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div>- Chuck<br></div></div></div></div></div></div></div> <br><div class="gmail_quote">On Thu, Aug 3, 2017 at 9:40 AM, Nicolai Hähnle <span dir="ltr"><<a href="mailto:nhaehnle@gmail.com" target="_blank">nhaehnle@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for doing this. For the series:<br> <br> Reviewed-by: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com" target="_blank">nicolai.haehnle@amd.com</a>><div><div class="h5"><br> <br> <br> On 02.08.2017 20:39, Emil Velikov wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> From: Emil Velikov <<a href="mailto:emil.velikov@collabora.com" target="_blank">emil.velikov@collabora.com</a>><br> <br> Expat versions prior to 2.1.0 lack the .pc file, so we need to do extra<br> gymnastics to detect it.<br> <br> Version 2.1.0 was released back in Mar 2012 and all major distributions<br> use it.<br> <br> Cc: Michel Dänzer <<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>><br> Signed-off-by: Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>><br> ---<br> Well... almost. Even Debian oldoldstable ships 2.1.0, although their<br> packaging seems busted - I cannot see the .pc file shipped anywhere.<br> <br> Michel, considering you have more Debian experience than me, can you<br> please forward the issue to the respective people.<br> <br> Would be great if we can finally drop this workaround.<br> <br> Thanks!<br> ---<br> <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 8 +-------<br> 1 file changed, 1 insertion(+), 7 deletions(-)<br> <br> diff --git a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> index 4988ecaf582..91717cbcd47 100644<br> --- a/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> +++ b/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> @@ -1792,13 +1792,7 @@ if test "x$with_dri_drivers" = xno; then<br> fi<br> # Check for expat<br> -PKG_CHECK_MODULES([EXPAT], [expat], [],<br> - # expat version 2.0 and earlier do not provide expat.pc<br> - [AC_CHECK_HEADER([expat.h],[],<br> - [AC_MSG_ERROR([Expat headers required for DRI not found])])<br> - AC_CHECK_LIB([expat],[XML_Par<wbr>serCreate],[],<br> - [AC_MSG_ERROR([Expat library required for DRI not found])])<br> - EXPAT_LIBS="-lexpat"])<br> +PKG_CHECK_MODULES([EXPAT], [expat])<br> dnl If $with_dri_drivers is yes, drivers will be added through<br> dnl platform checks. Set DEFINES and LIB_DEPS<br> <br> </blockquote> <br> <br> -- <br></div></div> Lerne, wie die Welt wirklich ist,<br> Aber vergiss niemals, wie sie sein sollte.<div class="HOEnZb"><div class="h5"><br> ______________________________<wbr>_________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> </div></div></blockquote></div><br></div></div></div></div></div></div>