<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 4, 2017 at 3:21 PM, Scott D Phillips <span dir="ltr"><<a href="mailto:scott.d.phillips@intel.com" target="_blank">scott.d.phillips@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">BLEND_STATE packing was modified to be variable-length in:<br>
<br>
9670124e31 genxml: Make BLEND_STATE command support variable length array.<br>
<br>
The initial gen10.xml still had the old, fixed-length style<br>
definition for BLEND_STATE. So gen10_upload_blend_state would<br>
overwrite the packed BLEND_STATE_ENTRYs with its own fixed array<br>
of all-zero entries when packing BLEND_STATE. This caused<br>
BLEND_STATE upload to not work at all.<br>
<br>
Fixes: aa416f515a ("i965/genxml: Add gen10.xml")<br>
---<br>
src/intel/genxml/gen10.xml | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen10.xml<br>
index 23c2adb995..a7ae49ae65 100644<br>
--- a/src/intel/genxml/gen10.xml<br>
+++ b/src/intel/genxml/gen10.xml<br>
@@ -554,7 +554,7 @@<br>
<field name="Write Disable Blue" start="0" end="0" type="bool"/><br>
</struct><br>
<br>
- <struct name="BLEND_STATE" length="17"><br>
+ <struct name="BLEND_STATE" length="1"><br>
<field name="Alpha To Coverage Enable" start="31" end="31" type="bool"/><br>
<field name="Independent Alpha Blend Enable" start="30" end="30" type="bool"/><br>
<field name="Alpha To One Enable" start="29" end="29" type="bool"/><br>
@@ -564,7 +564,7 @@<br>
<field name="Color Dither Enable" start="23" end="23" type="bool"/><br>
<field name="X Dither Offset" start="21" end="22" type="uint"/><br>
<field name="Y Dither Offset" start="19" end="20" type="uint"/><br>
- <group count="8" start="32" size="64"><br>
+ <group count="0" start="32" size="64"><br>
<field name="Entry" start="0" end="63" type="BLEND_STATE_ENTRY"/><br>
</group><br>
</struct><br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.11.0<br>
<br></font></span></blockquote><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline">LGTM. I think it'll fix many failing piglit tests on CNL. Thanks.</div></div><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline"><br></div></div><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline"></div>Reviewed-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>></div></div><br></div></div>