<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Aug 9, 2017 at 1:09 PM, Kenneth Graunke <span dir="ltr"><<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Also, silence an obnoxious finishme that started occurring for all<br>
GL applications which use stencil after the i965 ISL conversion.<br>
---<br>
src/intel/isl/isl.c | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c<br>
index 6b4203d79d2..c35116214c8 100644<br>
--- a/src/intel/isl/isl.c<br>
+++ b/src/intel/isl/isl.c<br>
@@ -1367,8 +1367,10 @@ isl_calc_row_pitch(const struct isl_device *dev,<br>
!pitch_in_range(row_pitch, _3DSTATE_HIER_DEPTH_BUFFER_<wbr>SurfacePitch_bits(dev->info)))<br>
return false;<br>
<br>
- if (surf_info->usage & ISL_SURF_USAGE_STENCIL_BIT)<br>
- isl_finishme("validate row pitch of stencil surfaces");<br>
+ if (dev->use_separate_stencil &&<br>
+ (surf_info->usage & ISL_SURF_USAGE_STENCIL_BIT) &&<br>
+ !pitch_in_range(row_pitch, _3DSTATE_STENCIL_BUFFER_<wbr>SurfacePitch_bits(dev->info)))<br></blockquote><div><br></div><div>Topi sent the same patch. This doesn't work on gen4.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ return false;<br>
<br>
done:<br>
*out_row_pitch = row_pitch;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.0<br>
<br>
</font></span></blockquote></div><br></div></div>