<div dir="ltr"><div>oof... Have you run this through Jenkins? It should be ok, but it will be a functional change. It's a good change, but it is a change. Also, this should probably get CCd to stable.<br><br></div>--Jason<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 9, 2017 at 3:52 PM, Scott D Phillips <span dir="ltr"><<a href="mailto:scott.d.phillips@intel.com" target="_blank">scott.d.phillips@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">intel_miptree_texture_aux_<wbr>usage() takes an isl_format, but we are<br>
passing a mesa_format. clang warns:<br>
<br>
brw_blorp.c:305:52: warning: implicit conversion from enumeration<br>
type 'mesa_format' to different enumeration type<br>
'enum isl_format' [-Wenum-conversion]<br>
intel_miptree_texture_aux_<wbr>usage(brw, src_mt, src_format);<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<wbr>~ ^~~~~~~~~~<br>
<br>
Fixes: fc1639e46d ("i965/blorp: Use texture/render_aux_usage for blits")<br>
---<br>
src/mesa/drivers/dri/i965/brw_<wbr>blorp.c | 3 ++-<br>
1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c b/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
index 446f507619..d8e48064e3 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
@@ -301,8 +301,9 @@ brw_blorp_blit_miptrees(struct brw_context *brw,<br>
src_format = dst_format = MESA_FORMAT_R_FLOAT32;<br>
}<br>
<br>
+ enum isl_format src_isl_format = brw_isl_format_for_mesa_<wbr>format(src_format);<br>
enum isl_aux_usage src_aux_usage =<br>
- intel_miptree_texture_aux_<wbr>usage(brw, src_mt, src_format);<br>
+ intel_miptree_texture_aux_<wbr>usage(brw, src_mt, src_isl_format);<br>
/* We do format workarounds for some depth formats so we can't reliably<br>
* sample with HiZ. One of these days, we should fix that.<br>
*/<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.13.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>