<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Aug 17, 2017 at 4:45 PM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 18/08/17 00:33, Jason Ekstrand wrote:<span class=""><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Aug 17, 2017 at 4:03 AM, Timothy Arceri <<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a> <mailto:<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>><wbr>> wrote:<br>
<br>
---<br>
src/mesa/drivers/dri/i965/brw_<wbr>context.c | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/br<wbr>w_context.c<br>
b/src/mesa/drivers/dri/i965/br<wbr>w_context.c<br>
index d97a24fbf8..8485e8a30c 100644<br>
--- a/src/mesa/drivers/dri/i965/br<wbr>w_context.c<br>
+++ b/src/mesa/drivers/dri/i965/br<wbr>w_context.c<br>
@@ -668,20 +668,26 @@ brw_initialize_context_constan<wbr>ts(struct<br>
brw_context *brw)<br>
ctx->Const.MaxVertexStreams = MIN2(4, MAX_VERTEX_STREAMS);<br>
<br>
/* ARB_framebuffer_no_attachments */<br>
ctx->Const.<wbr>MaxFramebufferWidth = 16384;<br>
ctx->Const.MaxFramebufferHeig<wbr>ht = 16384;<br>
ctx->Const.MaxFramebufferLaye<wbr>rs = ctx->Const.MaxArrayTextureLaye<wbr>rs;<br>
ctx->Const.MaxFramebufferSamp<wbr>les = max_samples;<br>
<br>
/* OES_primitive_bounding_box */<br>
ctx->Const.NoPrimitiveBoundin<wbr>gBoxOutput = true;<br>
+<br>
+ /* TODO: we should be able to use STD430 packing by default on<br>
all hardware<br>
+ * but some CTS tests currently fail on SNB when this is enabled.<br>
<br>
<br>
There is a very good reason for this. I know because I've come across it before. However, grepping through the code, I can't figure out why. :( What CTS tests start failing?<br>
</blockquote>
<br></span>
Project: piglit-test<br>
Test: piglit.spec.glsl-1_50.uniform_<wbr>buffer.gs-float-array-variable<wbr>-index<br>
Status: fail<br>
Platform/arch:<br>
snb/m64<br>
Command line: /tmp/build_root/m64/lib/piglit<wbr>/bin/shader_runner<br>
<br>
/tmp/build_root/m64/lib/piglit<wbr>/tests/spec/glsl-1.50/uniform_<wbr>buffer/gs-float-<br>
array-variable-index.shader_te<wbr>st -auto -fbo<br>
Project: piglit-test<br>
Test: piglit.spec.glsl-1_40.uniform_<wbr>buffer.vs-float-array-variable<wbr>-index<br>
Status: fail<br>
Platform/arch:<br>
snb/m64<br>
Command line: /tmp/build_root/m64/lib/piglit<wbr>/bin/shader_runner<br>
<br>
/tmp/build_root/m64/lib/piglit<wbr>/tests/spec/glsl-1.40/uniform_<wbr>buffer/vs-float-<br>
array-variable-index.shader_te<wbr>st -auto -fbo<br></blockquote><div><br></div><div>I did a bit of looking and the messages we're using for doing uniform pulls in the vec4 back-end on SNB is the OWORD block load instruction which takes its offset in units of OWORDS (16 bytes). On IVB+, we use the sampler which doesn't have these restrictions. Let's give it a proper comment.</div><div><br></div><div>--Jason<br></div><div> <br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
+ */<br>
+ if (brw->gen >= 7)<br>
+ ctx->Const.UseSTD430AsDefaultP<wbr>acking = true;<br>
}<br>
<br>
static void<br>
brw_initialize_cs_context_cons<wbr>tants(struct brw_context *brw)<br>
{<br>
struct gl_context *ctx = &brw->ctx;<br>
const struct intel_screen *screen = brw->screen;<br>
struct gen_device_info *devinfo = &brw->screen->devinfo;<br>
<br>
/* FINISHME: Do this for all platforms that the kernel supports */<br>
--<br>
2.13.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br></span>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a> <mailto:<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedes<wbr>ktop.org</a>><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
<<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org<wbr>/mailman/listinfo/mesa-dev</a>><br>
<br>
<br>
</blockquote>
</blockquote></div><br></div></div>