<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Aug 17, 2017 at 4:03 AM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
src/mesa/drivers/dri/i965/brw_<wbr>context.c | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_context.c b/src/mesa/drivers/dri/i965/<wbr>brw_context.c<br>
index d97a24fbf8..8485e8a30c 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>brw_context.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>brw_context.c<br>
@@ -668,20 +668,26 @@ brw_initialize_context_<wbr>constants(struct brw_context *brw)<br>
ctx->Const.MaxVertexStreams = MIN2(4, MAX_VERTEX_STREAMS);<br>
<br>
/* ARB_framebuffer_no_attachments */<br>
ctx->Const.MaxFramebufferWidth = 16384;<br>
ctx->Const.<wbr>MaxFramebufferHeight = 16384;<br>
ctx->Const.<wbr>MaxFramebufferLayers = ctx->Const.<wbr>MaxArrayTextureLayers;<br>
ctx->Const.<wbr>MaxFramebufferSamples = max_samples;<br>
<br>
/* OES_primitive_bounding_box */<br>
ctx->Const.<wbr>NoPrimitiveBoundingBoxOutput = true;<br>
+<br>
+ /* TODO: we should be able to use STD430 packing by default on all hardware<br>
+ * but some CTS tests currently fail on SNB when this is enabled.<br></blockquote><div><br></div><div>There is a very good reason for this. I know because I've come across it before. However, grepping through the code, I can't figure out why. :( What CTS tests start failing?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ */<br>
+ if (brw->gen >= 7)<br>
+ ctx->Const.<wbr>UseSTD430AsDefaultPacking = true;<br>
}<br>
<br>
static void<br>
brw_initialize_cs_context_<wbr>constants(struct brw_context *brw)<br>
{<br>
struct gl_context *ctx = &brw->ctx;<br>
const struct intel_screen *screen = brw->screen;<br>
struct gen_device_info *devinfo = &brw->screen->devinfo;<br>
<br>
/* FINISHME: Do this for all platforms that the kernel supports */<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.13.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>