<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 17, 2017 at 11:26 AM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro <span dir="ltr"><<a href="mailto:apinheiro@igalia.com" target="_blank">apinheiro@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Jose Maria Casanova Crespo <<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>><br>
<br>
---<br>
 src/compiler/nir/nir.h | 8 ++++++++<br>
 1 file changed, 8 insertions(+)<br>
<br>
diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h<br>
index 2ac5b1e..115ec1b 100644<br>
--- a/src/compiler/nir/nir.h<br>
+++ b/src/compiler/nir/nir.h<br>
@@ -107,6 +107,14 @@ typedef enum {<br>
 } nir_variable_mode;<br>
<br>
<br>
+typedef enum {<br>
+   nir_rounding_mode_undef = 0,<br>
+   nir_rounding_mode_rtne  = 1,<br>
+   nir_rounding_mode_ru    = 2,<br>
+   nir_rounding_mode_rd    = 3,<br>
+   nir_rounding_mode_rtz   = 4,<br></blockquote><div><br></div></span><div>Could we have either better names or a comment on each as to what it means.  Better names could be:</div><div><br></div><div>nir_rounding_mode_nearest_even</div><div>nir_rounding_mode_up</div><div>nir_rounding_mode_down</div><div>nir_rounding_mode_towards_zero</div><div><br></div><div>Things like "rtne" are less typing but hard to read.<span class="HOEnZb"><font color="#888888"><br></font></span></div></div></div></div></blockquote><div><br></div><div>And I just read patch 6 which is where abreviating things suddenly becomes useful...  Maybe it's best to just add comments?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="HOEnZb"><font color="#888888"><div>--Jason<br></div></font></span><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+} nir_rounding_mode;<br>
+<br>
 typedef union {<br>
    float f32[4];<br>
    double f64[4];<br>
<span class="m_-5081935001015375824HOEnZb"><font color="#888888">--<br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>