<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 18, 2017 at 4:28 AM, Eduardo Lima Mitev <span dir="ltr"><<a href="mailto:elima@igalia.com" target="_blank">elima@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 08/17/2017 08:48 PM, Jason Ekstrand wrote:<br>
> On Thu, Jul 13, 2017 at 7:35 AM, Alejandro Piñeiro <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a><br>
</span>> <mailto:<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>>> wrote:<br>
><br>
>     From: Eduardo Lima Mitev <<a href="mailto:elima@igalia.com">elima@igalia.com</a> <mailto:<a href="mailto:elima@igalia.com">elima@igalia.com</a>>><br>
<span class="">><br>
>     This will include the following NIR ALU opcodes:<br>
>      * nir_op_i2i16<br>
>      * nir_op_i2f16<br>
>      * nir_op_u2u16<br>
>      * nir_op_u2f16<br>
>      * nir_op_f2i16<br>
>      * nir_op_f2u16<br>
>      * nir_op_f2f16<br>
>     ---<br>
>      src/compiler/nir/nir_opcodes_<wbr>c.py | 2 +-<br>
>      1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
>     diff --git a/src/compiler/nir/nir_<wbr>opcodes_c.py<br>
>     b/src/compiler/nir/nir_<wbr>opcodes_c.py<br>
>     index a7721d3..01776be 100644<br>
>     --- a/src/compiler/nir/nir_<wbr>opcodes_c.py<br>
>     +++ b/src/compiler/nir/nir_<wbr>opcodes_c.py<br>
>     @@ -62,7 +62,7 @@ nir_type_conversion_op(nir_<wbr>alu_type src,<br>
>     nir_alu_type dst, nir_rounding_mode rnd<br>
>      %                 endif<br>
>      %              endif<br>
>                     switch (dst_bit_size) {<br>
>     -%                 for dst_bits in [32, 64]:<br>
>     +%                 for dst_bits in [16, 32, 64]:<br>
><br>
><br>
> You also need to update nir_type_conversion_op in nir_opcodes_c.py.<br>
><br>
<br>
</span>What do you mean? This hunk is for nir_type_conversion_op in<br>
<span class="">nir_opcodes_c.py.<br></span></blockquote><div><br></div><div>drp... I misread it as being for nir_opcodes.py but I guess we have all of those.  In that case,</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> Also, shouldn't this go before patch 6?<br>
><br>
<br>
</span>Yes, indeed. We have shuffled the patches in the series a few times<br>
already :). Fixed for v2.<br>
<span class=""><br>
><br>
>                        case ${dst_bits}:<br>
>      %                   if src_t == 'float' and dst_t == 'float'  and<br>
>     dst_bits == 16:<br>
>                           switch(rnd) {<br>
>     --<br>
>     2.9.3<br>
><br>
>     ______________________________<wbr>_________________<br>
>     mesa-dev mailing list<br>
</span>>     <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <mailto:<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.<wbr>freedesktop.org</a>><br>
>     <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
>     <<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.<wbr>org/mailman/listinfo/mesa-dev</a>><br>
<div class="HOEnZb"><div class="h5">><br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
><br>
<br>
</div></div></blockquote></div><br></div></div>