<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Aug 23, 2017 at 9:58 AM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
<br>
Did you submit a CTS bug?<br><div class="HOEnZb"><div class="h5"></div></div></blockquote><div><br></div><div>No, I didn't.  It does get some coverage through the up-and-coming subgroup tests but it should probably have it's own test.  That's going to be really annoying to test...<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
On 08/21/2017 10:11 PM, Jason Ekstrand wrote:<br>
> I have no idea how this got missed but it's been missing since forever.<br>
><br>
> Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.<wbr>org</a><br>
> ---<br>
>  src/compiler/spirv/vtn_<wbr>variables.c | 5 ++++-<br>
>  1 file changed, 4 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/src/compiler/spirv/vtn_<wbr>variables.c b/src/compiler/spirv/vtn_<wbr>variables.c<br>
> index 6a8776b..87cb935 100644<br>
> --- a/src/compiler/spirv/vtn_<wbr>variables.c<br>
> +++ b/src/compiler/spirv/vtn_<wbr>variables.c<br>
> @@ -1121,6 +1121,10 @@ vtn_get_builtin_location(<wbr>struct vtn_builder *b,<br>
>        *location = FRAG_RESULT_DEPTH;<br>
>        assert(*mode == nir_var_shader_out);<br>
>        break;<br>
> +   case SpvBuiltInHelperInvocation:<br>
> +      *location = SYSTEM_VALUE_HELPER_<wbr>INVOCATION;<br>
> +      set_mode_system_value(mode);<br>
> +      break;<br>
>     case SpvBuiltInNumWorkgroups:<br>
>        *location = SYSTEM_VALUE_NUM_WORK_GROUPS;<br>
>        set_mode_system_value(mode);<br>
> @@ -1177,7 +1181,6 @@ vtn_get_builtin_location(<wbr>struct vtn_builder *b,<br>
>        *location = SYSTEM_VALUE_VIEW_INDEX;<br>
>        set_mode_system_value(mode);<br>
>        break;<br>
> -   case SpvBuiltInHelperInvocation:<br>
>     default:<br>
>        unreachable("unsupported builtin");<br>
>     }<br>
><br>
<br>
</div></div></blockquote></div><br></div></div>