<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [bisected] Kodi crashes when launching a stream - commit bd2662bf"
href="https://bugs.freedesktop.org/show_bug.cgi?id=102530#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO - [bisected] Kodi crashes when launching a stream - commit bd2662bf"
href="https://bugs.freedesktop.org/show_bug.cgi?id=102530">bug 102530</a>
from <span class="vcard"><a class="email" href="mailto:alexandre.f.demers@gmail.com" title="Alexandre Demers <alexandre.f.demers@gmail.com>"> <span class="fn">Alexandre Demers</span></a>
</span></b>
<pre>(In reply to Erik Faye-Lund from <a href="show_bug.cgi?id=102530#c11">comment #11</a>)
<span class="quote">> (In reply to Timothy Arceri from <a href="show_bug.cgi?id=102530#c9">comment #9</a>)
> > (In reply to Erik Faye-Lund from <a href="show_bug.cgi?id=102530#c8">comment #8</a>)
> > > Something like this?
> > >
> > > ---8<---
> > >
> > > diff --git a/src/mesa/main/uniform_query.cpp
> > > b/src/mesa/main/uniform_query.cpp
> > > index c6488325a8..642c93270f 100644
> > > --- a/src/mesa/main/uniform_query.cpp
> > > +++ b/src/mesa/main/uniform_query.cpp
> > > @@ -911,6 +911,9 @@ _mesa_uniform(GLint location, GLsizei count, const
> > > GLvoid *values,
> > >
> > > struct gl_uniform_storage *uni;
> > > if (_mesa_is_no_error_enabled(ctx)) {
> > > + if (location == -1)
> > > + return;
> > > +
> > > uni = shProg->UniformRemapTable[location];
> > >
> > > /* The array index specified by the uniform location is just the
> > >
> > > ---8<---
> >
> > This was already fixed.
>
> OK, then I guess this commit was a false positive when bisecting, because it
> wasn't fixed in the commit this was tested against.</span >
By the way, if it was fixed, the fix may be occulted by <a class="bz_bug_link
bz_status_NEW "
title="NEW - [bisected] Kodi crashes since commit 707d2e8b - gallium: fold u_trim_pipe_prim call from st/mesa to drivers"
href="show_bug.cgi?id=102502">Bug 102502</a>. I first
reported 102502, which kills Kodi at launch, and I ended up finding the current
bug (102530) while bisecting the first one. Fixing 102502 may show that the
current bug is already fix then.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>