<div dir="auto"><div dir="auto">I'm busy until Sunday, but I'll see if I can find the time</div><div dir="auto">to address Nicolai's comments on Sunday evening.</div><div dir="auto">I've addressed the build issues with the tests, and the</div><div dir="auto">comment about using util_vsnprintf, so it's getting there.</div><div dir="auto">I've also done some general polishing on comments, etc.</div><div dir="auto"><br></div><div><br><div class="gmail_extra"><br><div class="gmail_quote">6. sep. 2017 23.00 skrev "Dieter Nützel" <<a href="mailto:Dieter@nuetzel-hh.de">Dieter@nuetzel-hh.de</a>>:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">For the series:<br>
<br>
Tested-by: Dieter Nützel <<a href="mailto:Dieter@nuetzel-hh.de" target="_blank">Dieter@nuetzel-hh.de</a>><br>
<br>
But do NOT apply on current git any longer.<br>
With Nicolai's comments addressed new version underway? ;-)<font color="#888888"><br>
<br>
Dieter</font><div class="elided-text"><br>
<br>
Am 29.08.2017 21:56, schrieb Thomas Helland:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This is a resend of the string buffer implementation and<br>
related patches sent out back in May. I've done one more<br>
change to the string buffer; using u_string.h for a compatible<br>
vsnprintf version to reduce the code even more. I've not been<br>
able to test this due to two build breakages (xmlpool and dri)<br>
that I'm still trying to figure out of. But since I promised<br>
to send these out this evening, I'm sending them untested.<br>
I did test them thoroughly the last time around though,<br>
so I believe it should be mostly good as long as I haven't<br>
messed up the rebasing. I believe the string buffer part of<br>
the series is the most important; the rest I've not really<br>
gotten around to performance test much.<br>
<br>
Thomas Helland (7):<br>
util: Add a string buffer implementation<br>
util: Add tests for the string buffer<br>
glsl: Change the parser to use the string buffer<br>
glcpp: Use string_buffer for line continuation removal<br>
glcpp: Avoid unnecessary call to strlen<br>
port to gtest<br>
fix test makefile<br>
<br>
Vladislav Egorov (1):<br>
glcpp: Use Bloom filter before identifier search<br>
<br>
<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 2 +<br>
src/compiler/glsl/glcpp/<wbr>glcpp-lex.l | 3 +-<br>
src/compiler/glsl/glcpp/<wbr>glcpp-parse.y | 219 ++++++++-------------<br>
src/compiler/glsl/glcpp/<wbr>glcpp.h | 18 +-<br>
src/compiler/glsl/glcpp/pp.c | 64 ++++---<br>
src/util/Makefile.am | 3 +-<br>
src/util/Makefile.sources | 2 +<br>
src/util/string_buffer.c | 155 +++++++++++++++<br>
src/util/string_buffer.h | 87 +++++++++<br>
src/util/tests/string_buffer/<wbr>Makefile.am | 38 ++++<br>
src/util/tests/string_buffer/<wbr>append_and_print.cpp | 221 ++++++++++++++++++++++<br>
11 files changed, 633 insertions(+), 179 deletions(-)<br>
create mode 100644 src/util/string_buffer.c<br>
create mode 100644 src/util/string_buffer.h<br>
create mode 100644 src/util/tests/string_buffer/M<wbr><a href="http://akefile.am">akefile.am</a><br>
create mode 100644 src/util/tests/string_buffer/a<wbr>ppend_and_print.cpp<br>
</blockquote>
</div></blockquote></div><br></div></div></div>