<div dir="ltr">Looks pretty good over-all. Most of the comments are on patch 1. I fully expect v3 to get merged. </div><div class="gmail_extra"> <div class="gmail_quote">On Mon, Aug 28, 2017 at 10:44 PM, Tapani Pälli <<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi; Here's v2 of VK_EXT_debug_report with fixes to issues found by Jason and for some issues that came up with crucible testing, I've pushed VK_EXT_debug_report support for crucible so that can be used for verifying the functionality. 2 last patches are resent, I think they got lost in the noise and are related to this functionality. Plan would be to hook spirv errors/warnings to this as well as other existing error reporting such as vk_error and couple of fprintfs. Thanks; Tapani Pälli (5): anv: implementation of VK_EXT_debug_report extension anv: wire up anv_perf_warn macro to do debug reporting anv: wire up vk_errorf macro to do debug reporting anv: move brw_process_intel_debug_variable to happen early anv: remove extra 'debug:' from anv_debug_ignored_stype src/intel/Makefile.sources | 1 + src/intel/vulkan/anv_allocator.c | 8 +- src/intel/vulkan/anv_debug_report.c | 124 +++++++++++++++++++++++++++++ src/intel/vulkan/anv_device.c | 91 ++++++++++++++++++---- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_formats.c | 3 +- src/intel/vulkan/anv_image.c | 12 +-- src/intel/vulkan/anv_private.h | 150 ++++++++++++++++++++++++++++++++++-- src/intel/vulkan/anv_queue.c | 13 ++-- src/intel/vulkan/anv_util.c | 22 +++++- src/intel/vulkan/anv_wsi.c | 6 +- src/intel/vulkan/genX_cmd_buffer.c | 12 ++- src/intel/vulkan/genX_query.c | 3 +- 13 files changed, 397 insertions(+), 49 deletions(-) create mode 100644 src/intel/vulkan/anv_debug_report.c -- 2.13.5 </blockquote></div> </div>