<html><head></head><body><div>Hi Jason,</div><div><br></div><div>thanks for the quick review! I agree with all your points and will update the series accordingly before pushing.</div><div><br></div><div>Iago</div><div><br></div><div>On Fri, 2017-09-15 at 17:11 -0700, Jason Ekstrand wrote:</div><blockquote type="cite"><div dir="ltr"><div>I don't think we need patches 2 or 6 and the commit message from 2 should probably go on 5. I left a comment on patch 4. Other than that, 1, 3, 4, and 5 are</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br><div><div class="gmail_extra"><div class="gmail_quote">On Fri, Sep 15, 2017 at 3:02 AM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote type="cite">Jason, Ken: I think this series addresses all your feedback, let me know<br>
if you think I missed anything.<br>
<br>
Maybe you also prefer to squash some of the patches, let me know if that<br>
is the case.<br>
<br>
Iago Toral Quiroga (6):<br>
i965: rename BRW_NEW_FAST_CLEAR_COLOR to BRW_NEW_AUX_STATE<br>
i965: emit BRW_NEW_AUX_STATE when we allocate aux surfaces<br>
i965: emit BRW_NEW_AUX_STATE if we drop the aux surface<br>
i965: emit BRW_NEW_AUX_STATE when we change the fast clear value<br>
i965: emit BRW_NEW_AUX_STATE on aux state changes<br>
i965: emit BRW_NEW_AUX_STATE for textures without unresolved colors<br>
<br>
src/mesa/drivers/dri/i965/brw_<wbr>blorp.c | 12 ++--------<br>
src/mesa/drivers/dri/i965/brw_<wbr>clear.c | 2 +-<br>
src/mesa/drivers/dri/i965/brw_<wbr>context.h | 4 ++--<br>
src/mesa/drivers/dri/i965/brw_<wbr>gs_surface_state.c | 2 +-<br>
src/mesa/drivers/dri/i965/brw_<wbr>state_upload.c | 2 +-<br>
src/mesa/drivers/dri/i965/brw_<wbr>tcs_surface_state.c | 2 +-<br>
src/mesa/drivers/dri/i965/brw_<wbr>tes_surface_state.c | 2 +-<br>
src/mesa/drivers/dri/i965/brw_<wbr>vs_surface_state.c | 2 +-<br>
src/mesa/drivers/dri/i965/brw_<wbr>wm_surface_state.c | 12 +++++-----<br>
src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 19 ++++++++++++---<br>
src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.h | 28 +++++++++++++++++++++++<br>
11 files changed, 60 insertions(+), 27 deletions(-)<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.11.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span><br></blockquote></div><br></div></div></div></div>
</blockquote></body></html>