<div dir="ltr"><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div>Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 22, 2017 at 3:22 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Kindly reminder that this patch is still unreviewed.<br>
<br>
Sam<br>
<div class="HOEnZb"><div class="h5"><br>
On Friday, September 15, 2017 11:50:46 AM CEST you wrote:<br>
> In Vulkan, for 'z' (depth) component, the scale and translate values<br>
> for the viewport transformation are:<br>
><br>
> pz = maxDepth - minDepth<br>
> oz = minDepth<br>
><br>
> zf = pz × zd + oz<br>
><br>
> Being zd, the third component in vertex's normalized device coordinates.<br>
><br>
> Fixes: dEQP-VK.draw.inverted_depth_<wbr>ranges.*<br>
><br>
> Signed-off-by: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
> ---<br>
> src/intel/vulkan/gen8_cmd_<wbr>buffer.c | 4 ++--<br>
> 1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/src/intel/vulkan/gen8_cmd_<wbr>buffer.c<br>
> b/src/intel/vulkan/gen8_cmd_<wbr>buffer.c index 064b8e930e..7bea231ea7 100644<br>
> --- a/src/intel/vulkan/gen8_cmd_<wbr>buffer.c<br>
> +++ b/src/intel/vulkan/gen8_cmd_<wbr>buffer.c<br>
> @@ -49,10 +49,10 @@ gen8_cmd_buffer_emit_viewport(<wbr>struct anv_cmd_buffer<br>
> *cmd_buffer) struct GENX(SF_CLIP_VIEWPORT) sf_clip_viewport = {<br>
> .ViewportMatrixElementm00 = vp->width / 2,<br>
> .ViewportMatrixElementm11 = vp->height / 2,<br>
> - .ViewportMatrixElementm22 = 1.0,<br>
> + .ViewportMatrixElementm22 = vp->maxDepth - vp->minDepth,<br>
> .ViewportMatrixElementm30 = vp->x + vp->width / 2,<br>
> .ViewportMatrixElementm31 = vp->y + vp->height / 2,<br>
> - .ViewportMatrixElementm32 = 0.0,<br>
> + .ViewportMatrixElementm32 = vp->minDepth,<br>
> .XMinClipGuardband = -1.0f,<br>
> .XMaxClipGuardband = 1.0f,<br>
> .YMinClipGuardband = -1.0f,<br>
<br>
</div></div><br>______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
<br></blockquote></div><br></div>