<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On 1 Oct. 2017 22:03, "Bas Nieuwenhuizen" <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Why add this? It sounds like extra code for no reason?<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Also why add it after the meta saves?</div><div dir="auto"><br></div><div dir="auto">Dave.</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="elided-text"><br>
On Fri, Sep 29, 2017 at 5:48 PM, Samuel Pitoiset<br>
<<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>> wrote:<br>
> This should be a no-op.<br>
><br>
> Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>><br>
> ---<br>
>  src/amd/vulkan/radv_meta_fast_<wbr>clear.c | 3 +++<br>
>  1 file changed, 3 insertions(+)<br>
><br>
> diff --git a/src/amd/vulkan/radv_meta_<wbr>fast_clear.c b/src/amd/vulkan/radv_meta_<wbr>fast_clear.c<br>
> index b92fb7cd5a..7e0738f44f 100644<br>
> --- a/src/amd/vulkan/radv_meta_<wbr>fast_clear.c<br>
> +++ b/src/amd/vulkan/radv_meta_<wbr>fast_clear.c<br>
> @@ -365,6 +365,9 @@ radv_fast_clear_flush_image_<wbr>inplace(struct radv_cmd_buffer *cmd_buffer,<br>
>         radv_meta_save_pass(&saved_<wbr>pass_state, cmd_buffer);<br>
>         radv_meta_save_graphics_reset_<wbr>vport_scissor_novertex(&saved_<wbr>state, cmd_buffer);<br>
><br>
> +       if (!image->cmask.size && !image->fmask.size && !image->dcc_offset)<br>
> +               return;<br>
> +<br>
>         if (image->surface.dcc_size) {<br>
>                 radv_emit_set_predication_<wbr>state_from_image(cmd_buffer, image, true);<br>
>                 cmd_buffer->state.predicating = true;<br>
> --<br>
> 2.14.2<br>
><br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></blockquote></div><br></div></div></div>