<div dir="auto">Yes, that is correct. </div><div class="gmail_extra"><br><div class="gmail_quote">On 2 Oct 2017 11:20, "Juan A. Suarez Romero" <<a href="mailto:jasuarez@igalia.com">jasuarez@igalia.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Small clarification: my understanding is that this patch is intended<br>
only for 17.2 stable release, right?<br>
<br>
As we already have 979978ee06867a5 in master for this.<br>
<br>
<br>
<br>
On Sun, 2017-10-01 at 10:07 +0200, Bas Nieuwenhuizen wrote:<br>
> Only on GFX9 we implement them as 2D images.<br>
><br>
> This fixes:<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_12x34<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_1x1<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_32x32<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_7x1<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_writeonly_12x34<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_writeonly_1x1<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_writeonly_32x32<br>
> dEQP-VK.image.image_size.1d_<wbr>array.readonly_writeonly_7x1<br>
> dEQP-VK.image.image_size.1d_<wbr>array.writeonly_12x34<br>
> dEQP-VK.image.image_size.1d_<wbr>array.writeonly_1x1<br>
> dEQP-VK.image.image_size.1d_<wbr>array.writeonly_32x32<br>
> dEQP-VK.image.image_size.1d_<wbr>array.writeonly_7x1<br>
><br>
> Fixes: 1bcb953e166 "radv: handle GFX9 1D textures"<br>
> Reviewed-by: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>><br>
> (cherry picked from commit 979978ee06867a531b8d56cee252f5<wbr>c83920a339)<br>
> ---<br>
> src/amd/common/ac_nir_to_llvm.<wbr>c | 3 ++-<br>
> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/src/amd/common/ac_nir_to_<wbr>llvm.c b/src/amd/common/ac_nir_to_<wbr>llvm.c<br>
> index 94e457d8ff8..95cc8e56092 100644<br>
> --- a/src/amd/common/ac_nir_to_<wbr>llvm.c<br>
> +++ b/src/amd/common/ac_nir_to_<wbr>llvm.c<br>
> @@ -3609,7 +3609,8 @@ static LLVMValueRef visit_image_size(struct nir_to_llvm_context *ctx,<br>
> z = LLVMBuildSDiv(ctx->builder, z, six, "");<br>
> res = LLVMBuildInsertElement(ctx-><wbr>builder, res, z, two, "");<br>
> }<br>
> - if (glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_1D &&<br>
> + if (ctx->options->chip_class >= GFX9 &&<br>
> + glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_1D &&<br>
> glsl_sampler_type_is_array(<wbr>type)) {<br>
> LLVMValueRef layers = LLVMBuildExtractElement(ctx-><wbr>builder, res, two, "");<br>
> res = LLVMBuildInsertElement(ctx-><wbr>builder, res, layers,<br>
</blockquote></div></div>