<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Oct 2, 2017 at 4:08 PM, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.<wbr>org</a><br>
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
---<br>
src/mesa/drivers/dri/i965/brw_<wbr>state_upload.c | 7 +++++--<br>
1 file changed, 5 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_state_upload.c b/src/mesa/drivers/dri/i965/<wbr>brw_state_upload.c<br>
index a1bf54dc72..c224355a2b 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>brw_state_upload.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>brw_state_upload.c<br>
@@ -88,8 +88,11 @@ brw_upload_initial_gpu_state(<wbr>struct brw_context *brw)<br>
if (devinfo->gen == 10) {<br>
BEGIN_BATCH(2);<br>
OUT_BATCH(_3DSTATE_3D_MODE << 16 | (2 - 2));<br>
- OUT_BATCH(GEN10_FLOAT_BLEND_<wbr>OPTIMIZATION_ENABLE << 16 |<br>
- GEN10_FLOAT_BLEND_<wbr>OPTIMIZATION_ENABLE);<br>
+ /* From gen10 workaround table in h/w specs:<br>
+ * "On 3DSTATE_3D_MODE, driver must always program bits 31:16 of DW1<br>
+ * a value of 0xFFFF"<br>
+ */<br>
+ OUT_BATCH(0xFFFF << 16 | GEN10_FLOAT_BLEND_<wbr>OPTIMIZATION_ENABLE);<br></blockquote><div><br></div><div>Bits 31:16 are the mask bits. By programming them to 0xFFFF, you're making it write the entire register and not just the float blend optimization enable bit. If we're going to do that, we need to figure out what values we want in the other fields and always set them along with the float blend optimization enable bit.</div><div><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
ADVANCE_BATCH();<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.13.5<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>