<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0" href="https://bugs.freedesktop.org/show_bug.cgi?id=103031#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [llvmpipe] piglit fs-discard-exit-2 fails with llvm-6.0" href="https://bugs.freedesktop.org/show_bug.cgi?id=103031">bug 103031</a> from <a class="email" href="mailto:vlee@freedesktop.org" title="Vinson Lee <vlee@freedesktop.org>"> Vinson Lee</a> <pre>(In reply to Roland Scheidegger from <a href="show_bug.cgi?id=103031#c1">comment #1</a>) > Created <a href="attachment.cgi?id=134554" name="attach_134554" title="patch accounting for llvm nuked pabs intrinsics">attachment 134554</a> <a href="attachment.cgi?id=134554&action=edit" title="patch accounting for llvm nuked pabs intrinsics">[details]</a> <a href='page.cgi?id=splinter.html&bug=103031&attachment=134554'>[review]</a> [review] > patch accounting for llvm nuked pabs intrinsics > > Does this patch work? > I'm also changing the non-intrinsic definition of pabs to basically match > what the auto-upgrader would do (if it would actually work for us...), so > that llvm should be able to hopefully match that back to a pabs in the end > (albeit the cmp/select has additional sext/trunc - I hope that doesn't > matter...) - the old code would have used a max, which would have to be > decomposed into a cmp/select too with newer llvm versions but it would have > used select(cmp(greater, a, neg(a))) instead of select(cmp(greater, a, 0), > neg(a)). Not sure if that would also get fused to a pabs instruction in the > end... Yes, this patch fixes the llvm.x86.avx2.pabs.d error.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>