<div dir="ltr"><div>Is there a test case for this? </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Oct 6, 2017 at 2:36 AM, Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">SpvOpImageFetch doesn't provide it, so set it to zero. Signed-off-by: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>> --- src/intel/compiler/brw_fs_nir.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index 5b8ccd50bff..25488303c29 100644 --- a/src/intel/compiler/brw_fs_nir.cpp +++ b/src/intel/compiler/brw_fs_nir.cpp @@ -4518,11 +4518,12 @@ fs_visitor::nir_emit_texture(const fs_builder &bld, nir_tex_instr *instr) unreachable("unknown texture opcode"); } - /* TXS and TXL require a LOD but not everything we implement using those - * two opcodes provides one. Provide a default LOD of 0. + /* TXF, TXS and TXL require a LOD but not everything we implement using those + * three opcodes provides one. Provide a default LOD of 0. */ - if ((opcode == SHADER_OPCODE_TXS_LOGICAL || - opcode == SHADER_OPCODE_TXL_LOGICAL) && + if ((opcode == SHADER_OPCODE_TXF_LOGICAL || + opcode == SHADER_OPCODE_TXS_LOGICAL || + opcode == SHADER_OPCODE_TXL_LOGICAL) && srcs[TEX_LOGICAL_SRC_LOD].file == BAD_FILE) { srcs[TEX_LOGICAL_SRC_LOD] = brw_imm_ud(0u); } -- 2.13.6 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>