<div dir="auto">Hi Ken,<br><div dir="auto">Sorry for missing this and thank you for catching it!</div><div dir="auto"><br></div><div dir="auto">Reviewed-by: Plamena Manolova <<a href="mailto:plamena.manolova@intel.com" target="_blank">plamena.manolova@intel.com</a>></div><div class="gmail_extra" dir="auto"><br><div class="gmail_quote">On 11 Oct 2017 03:27, "Kenneth Graunke" <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>> wrote:<br type="attribution"><blockquote class="m_-8369951706174445751quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The original implementation allocated a new BO here, but we decided to<br>
switch to intel_upload_space, which returns a reference to the current<br>
upload BO. We accidentally kept the brw_bo_alloc, even though it's no<br>
longer necessary - intel_upload_space will immediately unreference it,<br>
causing us to allocate and immediately free a buffer.<br>
<br>
Cc: Plamena Manolova <<a href="mailto:plamena.n.manolova@gmail.com" target="_blank">plamena.n.manolova@gmail.com</a>><br>
---<br>
src/mesa/drivers/dri/i965/<wbr>brw_draw.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/br<wbr>w_draw.c b/src/mesa/drivers/dri/i965/br<wbr>w_draw.c<br>
index d6aa95b6f60..8f616e76c0d 100644<br>
--- a/src/mesa/drivers/dri/i965/br<wbr>w_draw.c<br>
+++ b/src/mesa/drivers/dri/i965/br<wbr>w_draw.c<br>
@@ -903,7 +903,7 @@ brw_draw_prims(struct gl_context *ctx,<br>
for (i = 0; i < nr_prims; i++) {<br>
/* Implementation of ARB_indirect_parameters via predicates */<br>
if (brw->draw.draw_params_count_b<wbr>o) {<br>
- struct brw_bo *draw_id_bo = brw_bo_alloc(brw->bufmgr, "draw_id", 4, 4);<br>
+ struct brw_bo *draw_id_bo;<br>
uint32_t draw_id_offset;<br>
<br>
intel_upload_data(brw, &prims[i].draw_id, 4, 4, &draw_id_bo,<br>
<font color="#888888">--<br>
2.14.2<br>
<br>
</font></blockquote></div><br></div></div>