<div dir="auto"><div><div class="gmail_extra"><br><div class="gmail_quote">On 12 Oct. 2017 15:40, "Tapani Pälli" <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text"><br>
<br>
On 10/12/2017 02:34 AM, Dave Airlie wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Dave Airlie <<a href="mailto:airlied@redhat.com" target="_blank">airlied@redhat.com</a>><br>
<br>
When I realigned the bufferobj code, I didn't see the getters<br>
were different, realign the getters to work the same as ssbo.<br>
</blockquote>
<br></div>
Alternatively you could set these values as 0 in bind_buffer_base_atomic_buffer<wbr>()? Not sure if it's any better but then value would match internally what it has been before these changes.</blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Before these changes the ssbo and atomic code was gratuitously different, this is just the last piece of making them consistent.</div><div dir="auto"><br></div><div dir="auto">Dave </div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=103214" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=103214</a><br>
Fixes: 65d3ef7cd (mesa: align atomic buffer handling code with ubo/ssbo (v1.1))<br>
Signed-off-by: Dave Airlie <<a href="mailto:airlied@redhat.com" target="_blank">airlied@redhat.com</a>><br>
---<br>
src/mesa/main/get.c | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c<br>
index 4c4a4a7..e68a93b 100644<br>
--- a/src/mesa/main/get.c<br>
+++ b/src/mesa/main/get.c<br>
@@ -2349,7 +2349,8 @@ find_value_indexed(const char *func, GLenum pname, GLuint index, union value *v)<br>
goto invalid_enum;<br>
if (index >= ctx->Const.MaxAtomicBufferBind<wbr>ings)<br>
goto invalid_value;<br>
- v->value_int64 = ctx->AtomicBufferBindings[inde<wbr>x].Offset;<br>
+ v->value_int64 = ctx->AtomicBufferBindings[inde<wbr>x].Offset < 0 ? 0 :<br>
+ ctx->AtomicBufferBindings[ind<wbr>ex].Offset;<br>
return TYPE_INT64;<br>
case GL_ATOMIC_COUNTER_BUFFER_SIZE:<br>
@@ -2357,7 +2358,8 @@ find_value_indexed(const char *func, GLenum pname, GLuint index, union value *v)<br>
goto invalid_enum;<br>
if (index >= ctx->Const.MaxAtomicBufferBind<wbr>ings)<br>
goto invalid_value;<br>
- v->value_int64 = ctx->AtomicBufferBindings[inde<wbr>x].Size;<br>
+ v->value_int64 = ctx->AtomicBufferBindings[inde<wbr>x].Size < 0 ? 0 :<br>
+ ctx->AtomicBufferBindings[ind<wbr>ex].Size;<br>
return TYPE_INT64;<br>
case GL_VERTEX_BINDING_DIVISOR:<br>
<br>
</blockquote>
</div></blockquote></div><br></div></div></div>