<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Oct 23, 2017 at 11:10 AM, Eric Engestrom <span dir="ltr"><<a href="mailto:eric.engestrom@imgtec.com" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">eric.engestrom@imgtec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote:<br>
> I'm working on radeonsi support in the Chrome OS Android container<br>
> (ARC++). Mesa in ARC++ uses autotools instead of Android.mk, but all<br>
> the necessary EGL bits are there, so the existing check is too strict.<br>
><br>
> Signed-off-by: Benjamin Gordon <<a href="mailto:bmgordon@chromium.org" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">bmgordon@chromium.org</a>><br>
<br>
</span>Didn't double-check that all the android bits are wired, but I don't<br>
think this can break anything outside android, so:<br>
Reviewed-by: Eric Engestrom <<a href="mailto:eric.engestrom@imgtec.com" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">eric.engestrom@imgtec.com</a>><br>
<br>
Do you need someone to push this for you?<br></blockquote><div><br></div><div>Yes, please :)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
> ---<br>
> <a href="http://configure.ac" rel="noreferrer" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">configure.ac</a> | 3 ++-<br>
> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/<a href="http://configure.ac" rel="noreferrer" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">configure.ac</a> b/<a href="http://configure.ac" rel="noreferrer" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">configure.ac</a><br>
> index e05c34eb7b..b971b36333 100644<br>
> --- a/<a href="http://configure.ac" rel="noreferrer" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">configure.ac</a><br>
> +++ b/<a href="http://configure.ac" rel="noreferrer" class="m_8891525881520169824m_-6729829386270541005cremed m_8891525881520169824cremed cremed" target="_blank">configure.ac</a><br>
> @@ -2393,12 +2393,13 @@ dnl Surfaceless is an alternative for the last one.<br>
> dnl<br>
> require_basic_egl() {<br>
> case "$with_platforms" in<br>
> - *drm*|*surfaceless*)<br>
> + *drm*|*surfaceless*|*android*)<br>
> ;;<br>
> *)<br>
> AC_MSG_ERROR([$1 requires one of these:<br>
> 1) --with-platforms=drm (X, Wayland, offscreen rendering based on DRM)<br>
> 2) --with-platforms=surfaceless (offscreen only)<br>
> + 3) --with-platforms=android (Android only)<br>
> Recommended options: drm,x11])<br>
> ;;<br>
> esac<br>
> --<br>
> 2.15.0.rc0.271.g36b669edcc-goo<wbr>g<br>
</span> ^^^^<br>
Side note, do you guys have google builds of git?<br></blockquote><div><br></div><div>We probably do, but I'm afraid I don't have any idea what's in it. There are several git contributors working here, so maybe stuff that they haven't finished upstreaming yet?</div></div><br></div><div class="gmail_extra"><br></div></div>