<div dir="ltr">Hi Gwan-gyeong,<div><br></div><div>You should use <span style="font-size:12.8px">dri2_surface_free_image in the next patchset you send out (should be pretty easy to implement), but can save the polishing of struct dri2_egl_surface for later.</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 23, 2017 at 1:46 PM, Mun, Gwan-gyeong <span dir="ltr"><<a href="mailto:elongbug@gmail.com" target="_blank">elongbug@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Gurchetan,<br>
<span class=""><br>
2017-10-18 6:02 GMT+09:00 Gurchetan Singh <<a href="mailto:gurchetansingh@chromium.org">gurchetansingh@chromium.org</a>>:<br>
> dri2_egl_surface_destroy_<wbr>image_front and dri2_egl_surface_destroy_<wbr>image_back<br>
> are almost identical.  Why don't you just create a<br>
> dri2_surface_free_image(struct dri2_egl_surface *dri2_surf, __DRIimage<br>
> **img) that you will call with both the front and back images?  In addition,<br>
<br>
</span>As your opinion, we can rafactor more for dri2_surface_free_image.<br>
<br>
Nevertheless however, I'd suggest keeping that as separate series.<br>
these patches started as a way to minimise the duplication we have in<br>
drivers/dri2.<br>
So that new platforms such as Tizen do not need to copy the lot. [1]<br>
<span class=""><br>
> only platform_android has dri_image_back and dri_image_front -- please keep<br>
<br>
</span>In this patch, dri2_egl_surface_destroy_<wbr>image_front() helper is only<br>
used for android<br>
however it will also be used for new platform (Tizen). [2]<br>
<br>
[1] <a href="https://lists.freedesktop.org/archives/mesa-dev/2017-October/173269.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>archives/mesa-dev/2017-<wbr>October/173269.html</a><br>
[2] <a href="https://lists.freedesktop.org/archives/mesa-dev/2017-October/172007.html" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>archives/mesa-dev/2017-<wbr>October/172007.html</a><br>
<br>
<br>
Thanks,<br>
<br>
Gwan-gyeong<br>
</blockquote></div><br></div>