<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">This patch should really be squashed in with the next one.<br></div><div class="gmail_quote"><br></div><div class="gmail_quote">On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo <span dir="ltr"><<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Alejandro Piñeiro <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>><br>
<br>
---<br>
src/intel/compiler/brw_fs_nir.<wbr>cpp | 6 +++---<br>
1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs_<wbr>nir.cpp b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
index b356836e80..e108b5517b 100644<br>
--- a/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
+++ b/src/intel/compiler/brw_fs_<wbr>nir.cpp<br>
@@ -4056,11 +4056,10 @@ fs_visitor::nir_emit_<wbr>intrinsic(const fs_builder &bld, nir_intrinsic_instr *instr<br>
* Also, we have to suffle 64-bit data to be in the appropriate layout<br>
* expected by our 32-bit write messages.<br>
*/<br>
- unsigned type_size = 4;<br>
unsigned bit_size = instr->src[0].is_ssa ?<br>
instr->src[0].ssa->bit_size : instr->src[0].reg.reg->bit_<wbr>size;<br>
+ unsigned type_size = bit_size / 8;<br>
if (bit_size == 64) {<br>
- type_size = 8;<br>
fs_reg tmp =<br>
fs_reg(VGRF, alloc.allocate(alloc.sizes[<a href="http://val_reg.nr" rel="noreferrer" target="_blank">val<wbr>_reg.nr</a>]), val_reg.type);<br>
shuffle_64bit_data_for_32bit_<wbr>write(bld,<br>
@@ -4070,7 +4069,8 @@ fs_visitor::nir_emit_<wbr>intrinsic(const fs_builder &bld, nir_intrinsic_instr *instr<br>
val_reg = tmp;<br>
}<br>
<br>
- unsigned type_slots = type_size / 4;<br>
+ /* 16-bit types would use a minimum of 1 slot */<br>
+ unsigned type_slots = MAX2(type_size / 4, 1);<br>
<br>
/* Combine groups of consecutive enabled channels in one write<br>
* message. We use ffs to find the first enabled channel and then ffs on<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.13.6<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>