<div dir="ltr">Thank you for helping me out with this Ken!</div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Oct 31, 2017 at 3:50 AM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Monday, October 30, 2017 2:14:24 PM PDT Plamena Manolova wrote: > This patch modifies the ARB_indirect_parameters logic in > brw_draw_prims, so that our implementation isn't affected if > another application attempts to use predicates. Previously we > were using a predicate with a DELTAS_EQUAL comparison operation > and relying on the MI_PREDICATE_DATA register being 0. Our code > to initialize MI_PREDICATE_DATA to 0 was incorrect, so we were > accidentally using whatever value was written there. Because the > kernel does not initialize the MI_PREDICATE_DATA register on > hardware context creation, we might inherit the value from whatever > context was last running on the GPU (likely another process). > The Haswell command parser also does not currently allow us to write > the MI_PREDICATE_DATA register. Rather than fixing this and requiring > an updated kernel, we switch to a different approach which uses a > SRCS_EQUAL predicate that makes no assumptions about the states of any > of the predicate registers. > > Fixes: piglit.spec.arb_indirect_parameters.tf-count-arrays > Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=103085" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=103085</a> > > Signed-off-by: Plamena Manolova <<a href="mailto:plamena.manolova@intel.com">plamena.manolova@intel.com</a>> Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>> and pushed. Thanks Pam! </blockquote></div> </div>