<div dir="ltr">Do either of you mind if I cc the first one to stable?  It does fix a potential memory leak in the case where compilation fails.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 1, 2017 at 9:26 AM, Tapani Pälli <span dir="ltr"><<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">series<br>
Reviewed-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>><div class="HOEnZb"><div class="h5"><br>
<br>
On 11/01/2017 06:00 PM, Jason Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It doesn't actually matter since the only user of push constants, i965,<br>
ralloc_steals it back to NULL but it's more consistent and probably<br>
fixes memory leaks in some error cases.<br>
---<br>
  src/intel/compiler/brw_fs.cpp | 2 +-<br>
  1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs.cp<wbr>p b/src/intel/compiler/brw_fs.cp<wbr>p<br>
index e546792..21ff030 100644<br>
--- a/src/intel/compiler/brw_fs.cp<wbr>p<br>
+++ b/src/intel/compiler/brw_fs.cp<wbr>p<br>
@@ -2095,7 +2095,7 @@ fs_visitor::assign_constant_lo<wbr>cations()<br>
     stage_prog_data->param = ralloc_array(mem_ctx, uint32_t, num_push_constants);<br>
     if (num_pull_constants > 0) {<br>
        stage_prog_data->nr_pull_param<wbr>s = num_pull_constants;<br>
-      stage_prog_data->pull_param = ralloc_array(NULL, uint32_t,<br>
+      stage_prog_data->pull_param = ralloc_array(mem_ctx, uint32_t,<br>
                                                   num_pull_constants);<br>
     }<br>
  <br>
</blockquote>
</div></div></blockquote></div><br></div>