<div dir="auto">That's actually a pretty good suggestion, as it would help me get my feet wet on piglit changes with something simple.<div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Andres </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Nov 2, 2017 1:24 AM, "Timothy Arceri" <<a href="mailto:tarceri@itsqueeze.com">tarceri@itsqueeze.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 02/11/17 15:12, Andres Rodriguez wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It was tested against steamvr using an opengl vr client (hellovr_opengl for simplicity).<br>
</blockquote>
<br>
Hi Andres,<br>
<br>
Full tests would be great but at the very least we should start with some piglit tests that exercise the error paths.<br>
<br>
Tim<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Regards,<br>
Andres<br>
<br>
<br>
On 2017-11-02 12:07 AM, Jason Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Out of curiosity, how has this series been tested beyond regression testing?<br>
<br>
<br>
On November 1, 2017 20:57:57 Andres Rodriguez <<a href="mailto:andresx7@gmail.com" target="_blank">andresx7@gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This series adds radeonsi support for GL_EXT_semaphore.<br>
<br>
GL_EXT_semaphore is used by steam's vrclient to synchronize access to shared<br>
surfaces (vulkan <-> gl interop). It allows our gl vrclients to enqueue their<br>
framebuffer surface without waiting for a glFinish().<br>
<br>
If anyone has any suggestions on improvements for the implicit flush added in<br>
patch 9 please let me know. Either a way to remove it, or a way to move it to<br>
a codepath that is a bit more specific to radeonsi.<br>
<br>
Test results for this series (pretty alpha quality auto testing):<br>
<a href="https://lostgoat.me/gpuci/jenkins/blue/organizations/jenkins/amdgpu-reviews/detail/amdgpu-reviews/184/pipeline" rel="noreferrer" target="_blank">https://lostgoat.me/gpuci/jenk<wbr>ins/blue/organizations/jenkins<wbr>/amdgpu-reviews/detail/amdgpu-<wbr>reviews/184/pipeline</a> <br>
<br>
Test results for each individual patch can also be found here (see 'Related<br>
Changes' section):<br>
<a href="https://gerrit.lostgoat.me/#/c/454/" rel="noreferrer" target="_blank">https://gerrit.lostgoat.me/#/c<wbr>/454/</a><br>
<br>
And here is a baseline for test results for comparison:<br>
<a href="https://lostgoat.me/gpuci/jenkins/blue/organizations/jenkins/amdgpu-master/detail/amdgpu-master/1269/tests" rel="noreferrer" target="_blank">https://lostgoat.me/gpuci/jenk<wbr>ins/blue/organizations/jenkins<wbr>/amdgpu-master/detail/amdgpu-<wbr>master/1269/tests</a> <br>
<br>
Tests include Vulkan CTS and piglit on Kaveri and Polaris 10.<br>
<br>
I just kicked off the tests, so they might still show in a queued/in progress<br>
state for a few hours. Hopefully my ryzen server and my test slaves survive the<br>
unsupervised effort (*fingers crossed it doesn't catch fire while I sleep*).<br>
<br>
Patches 1-12 add support for semaphore wait/signal/import<br>
Patch 13 implements buffer/texture barriers<br>
Patches 14-16 implement layout transitions<br>
Patch 17 exposes the extension<br>
<br>
Andres Rodriguez (17):<br>
gallium: introduce PIPE_CAP_SEMAPHORE<br>
mesa/st: expose EXT_semaphore and EXT_semaphore_fd<br>
mesa: add support for semaphore object creation/import/delete<br>
mesa: add semaphore parameter stub<br>
gallium: introduce semaphore object<br>
u_threaded_context: add support for semaphore wait/signal<br>
mesa/st: add support for semaphore object create/import/delete<br>
mesa: add support for semaphore object signal/wait<br>
mesa/st: add support for waiting for semaphore objects<br>
mesa: minor tidy up for memory object error strings<br>
winsys/amdgpu: add support for syncobj signaling<br>
radeonsi: implement semaphore operations<br>
mesa: implement buffer/texture barriers for semaphore wait/signal<br>
gallium: add transition_resource call<br>
mesa/st: hook up resource transitions for semaphore calls<br>
radeonsi: implement pipe transition_resource callback<br>
radeonsi: advertise support for GL_EXT_semaphore<br>
<br>
src/gallium/auxiliary/util/u_<wbr>threaded_context.c | 52 ++++<br>
.../auxiliary/util/u_threaded<wbr>_context_calls.h | 1 +<br>
src/gallium/docs/source/scree<wbr>n.rst | 1 +<br>
src/gallium/drivers/ddebug/dd<wbr>_context.c | 23 ++<br>
src/gallium/drivers/ddebug/dd<wbr>_screen.c | 25 ++<br>
src/gallium/drivers/etnaviv/e<wbr>tnaviv_screen.c | 1 +<br>
src/gallium/drivers/freedreno<wbr>/freedreno_screen.c | 1 +<br>
src/gallium/drivers/i915/i915<wbr>_screen.c | 1 +<br>
src/gallium/drivers/llvmpipe/<wbr>lp_screen.c | 1 +<br>
src/gallium/drivers/nouveau/n<wbr>v30/nv30_screen.c | 1 +<br>
src/gallium/drivers/nouveau/n<wbr>v50/nv50_screen.c | 1 +<br>
src/gallium/drivers/nouveau/n<wbr>vc0/nvc0_screen.c | 1 +<br>
src/gallium/drivers/r300/r300<wbr>_screen.c | 1 +<br>
src/gallium/drivers/r600/r600<wbr>_pipe.c | 1 +<br>
src/gallium/drivers/radeon/r6<wbr>00_pipe_common.c | 52 ++++<br>
src/gallium/drivers/radeon/r6<wbr>00_pipe_common.h | 5 +<br>
src/gallium/drivers/radeon/ra<wbr>deon_winsys.h | 12 +<br>
src/gallium/drivers/radeonsi/<wbr>si_blit.c | 11 +<br>
src/gallium/drivers/radeonsi/<wbr>si_pipe.c | 3 +<br>
src/gallium/drivers/softpipe/<wbr>sp_screen.c | 1 +<br>
src/gallium/drivers/svga/svga<wbr>_screen.c | 1 +<br>
src/gallium/drivers/swr/swr_s<wbr>creen.cpp | 1 +<br>
src/gallium/drivers/trace/tr_<wbr>context.c | 36 +++<br>
src/gallium/drivers/trace/tr_<wbr>screen.c | 39 +++<br>
src/gallium/drivers/vc4/vc4_s<wbr>creen.c | 1 +<br>
src/gallium/drivers/virgl/vir<wbr>gl_screen.c | 1 +<br>
src/gallium/include/pipe/p_co<wbr>ntext.h | 36 +++<br>
src/gallium/include/pipe/p_de<wbr>fines.h | 12 +<br>
src/gallium/include/pipe/p_sc<wbr>reen.h | 22 ++<br>
src/gallium/include/pipe/p_st<wbr>ate.h | 8 +<br>
src/gallium/winsys/amdgpu/drm<wbr>/amdgpu_cs.c | 81 +++++-<br>
src/gallium/winsys/amdgpu/drm<wbr>/amdgpu_cs.h | 4 +<br>
src/mesa/Makefile.sources <wbr> | 2 +<br>
src/mesa/drivers/common/drive<wbr>rfuncs.c | 3 +<br>
src/mesa/main/dd.h <wbr> | 58 +++++<br>
src/mesa/main/extensions_tabl<wbr>e.h | 2 +<br>
src/mesa/main/externalobjects<wbr>.c | 274 +++++++++++++++++++--<br>
src/mesa/main/externalobjects<wbr>.h | 34 ++-<br>
src/mesa/main/mtypes.h <wbr> | 9 +<br>
src/mesa/main/shared.c <wbr> | 17 ++<br>
src/mesa/meson.build <wbr> | 2 +<br>
src/mesa/state_tracker/st_cb_<wbr>semaphoreobjects.c | 164 ++++++++++++<br>
src/mesa/state_tracker/st_cb_<wbr>semaphoreobjects.h | 25 ++<br>
src/mesa/state_tracker/st_con<wbr>text.c | 2 +<br>
src/mesa/state_tracker/st_ext<wbr>ensions.c | 2 +<br>
45 files changed, 1012 insertions(+), 19 deletions(-)<br>
create mode 100644 src/mesa/state_tracker/st_cb_s<wbr>emaphoreobjects.c<br>
create mode 100644 src/mesa/state_tracker/st_cb_s<wbr>emaphoreobjects.h<br>
<br>
-- <br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote>
<br>
<br>
</blockquote>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote>
</blockquote></div></div>