<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Nov 6, 2017 at 12:56 AM, Pohjolainen, Topi <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Fri, Nov 03, 2017 at 04:17:31PM -0700, Jason Ekstrand wrote:<br>
> ---<br>
>Â src/intel/blorp/blorp_genX_<wbr>exec.h | 6 +-----<br>
>Â 1 file changed, 1 insertion(+), 5 deletions(-)<br>
><br>
> diff --git a/src/intel/blorp/blorp_genX_<wbr>exec.h b/src/intel/blorp/blorp_genX_<wbr>exec.h<br>
> index 5389262..ccbfe51 100644<br>
> --- a/src/intel/blorp/blorp_genX_<wbr>exec.h<br>
> +++ b/src/intel/blorp/blorp_genX_<wbr>exec.h<br>
> @@ -1364,11 +1364,7 @@ blorp_emit_depth_stencil_<wbr>config(struct blorp_batch *batch,<br>
>Â Â Â Â return;<br>
><br>
>Â Â Â struct isl_depth_stencil_hiz_emit_<wbr>info info = {<br>
> -#if GEN_GEN >= 7<br>
> -Â Â Â .mocs = 1, /* GEN7_MOCS_L3 */<br>
> -#else<br>
> -Â Â Â .mocs = 0,<br>
> -#endif<br>
> +Â Â Â .mocs = batch->blorp->mocs.tex,<br>
<br>
</span>Need to ask some questions here:<br>
<br>
It looks that the old value "1" was invalid for gen8+, how did that work?<br></blockquote><div><br></div><div>I have no idea. :)<br></div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Looking at brw_blorp_init(), we now start supplying *_MOCS_WB for gen8+. Does<br>
that work also for HIZ ops or do we need mocs::rb?<span class=""><br></span></blockquote><div><br></div><div>I looked at gen8_depth_state.c to make this choice. There, we we use MOCS_WB for gen8+.<br></div></div><br></div></div>