<div dir="ltr">This is a really rubbish solution. Yes, it fixes a crash in MPV but unless we disable all blorp on gen4-5 (which I don't think is possible anymore), we haven't actually fixed it for real. </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Nov 9, 2017 at 7:21 AM, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>> Using the codepath leads to a crashes in MPV's fullscreen mode. Disable temporarily, until we can investigate and address properly. Cc: Adesh <<a href="mailto:adeshk@hotmail.com">adeshk@hotmail.com</a>> Cc: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>> Cc: Dylan Baker <<a href="mailto:dylanx.c.baker@intel.com">dylanx.c.baker@intel.com</a>> Cc: Mark Janes <<a href="mailto:mark.a.janes@intel.com">mark.a.janes@intel.com</a>> Fixes: 79f2a5541f9 ("i965: Use BLORP for color clears on gen4-5") Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=103529" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=103529</a> Signed-off-by: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>> --- src/mesa/drivers/dri/i965/brw_clear.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_clear.c b/src/mesa/drivers/dri/i965/brw_clear.c index fe8634b3b34..6808ddfb93c 100644 --- a/src/mesa/drivers/dri/i965/brw_clear.c +++ b/src/mesa/drivers/dri/i965/brw_clear.c @@ -293,7 +293,10 @@ brw_clear(struct gl_context *ctx, GLbitfield mask) mt->stencil_mt->r8stencil_needs_update = true; } - if (mask & BUFFER_BITS_COLOR) { + /* TODO: Look into the mpv crash on g4x and enable BLORP color clears for + * all platforms. See: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=103529" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=103529</a> + */ + if (brw->gen >= 6 && (mask & BUFFER_BITS_COLOR)) { brw_blorp_clear_color(brw, fb, mask, partial_clear, ctx->Color.sRGBEnabled); debug_mask("blorp color", mask & BUFFER_BITS_COLOR); -- 2.14.1 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>