<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Nov 27, 2017 at 7:00 PM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I am strongly in favor of this precedent.  One thing that has annoyed me<br>
for years about Mesa's OpenGL code is the use of mixed suffixes through<br>
the code base as an extension progresses from vendor -> EXT -> ARB -> core.<br></blockquote><div><br></div><div>I'm having a bit of trouble with English, I'm afraid.  I'm not sure if that means you like the patch or hate it.  In any case, the related extension is *not* in core and the lack of suffixes was a bug. The header/XML update I sent out as patch 1/3 will break the radv build if we don't have this patch.</div><div><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
On 11/27/2017 06:36 PM, Jason Ekstrand wrote:<br>
> ---<br>
>  src/amd/vulkan/radv_device.c | 8 ++++----<br>
>  1 file changed, 4 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c<br>
> index 722c768..8e5ae0b 100644<br>
> --- a/src/amd/vulkan/radv_device.c<br>
> +++ b/src/amd/vulkan/radv_device.c<br>
> @@ -895,13 +895,13 @@ radv_get_queue_global_<wbr>priority(const VkDeviceQueueGlobalPriorityCre<wbr>ateInfoEXT *p<br>
>               return RADEON_CTX_PRIORITY_MEDIUM;<br>
><br>
>       switch(pObj->globalPriority) {<br>
> -     case VK_QUEUE_GLOBAL_PRIORITY_<wbr>REALTIME:<br>
> +     case VK_QUEUE_GLOBAL_PRIORITY_<wbr>REALTIME_EXT:<br>
>               return RADEON_CTX_PRIORITY_REALTIME;<br>
> -     case VK_QUEUE_GLOBAL_PRIORITY_HIGH:<br>
> +     case VK_QUEUE_GLOBAL_PRIORITY_HIGH_<wbr>EXT:<br>
>               return RADEON_CTX_PRIORITY_HIGH;<br>
> -     case VK_QUEUE_GLOBAL_PRIORITY_<wbr>MEDIUM:<br>
> +     case VK_QUEUE_GLOBAL_PRIORITY_<wbr>MEDIUM_EXT:<br>
>               return RADEON_CTX_PRIORITY_MEDIUM;<br>
> -     case VK_QUEUE_GLOBAL_PRIORITY_LOW:<br>
> +     case VK_QUEUE_GLOBAL_PRIORITY_LOW_<wbr>EXT:<br>
>               return RADEON_CTX_PRIORITY_LOW;<br>
>       default:<br>
>               unreachable("Illegal global priority value");<br>
><br>
<br>
</div></div></blockquote></div><br></div></div>