<div dir="ltr"><div>It would be helpful to add a /* BRW_NEW_*_PROGRAM */ comment to get_pipeline_state_l3_weights. With that, </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Nov 15, 2017 at 1:29 PM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This looks at prog->*. You don't get to do that unless you listen to BRW_NEW_*_PROGRAM, which is a superset of the cases where BRW_NEW_*_PROG_DATA is flagged. --- src/mesa/drivers/dri/i965/gen7_l3_state.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen7_l3_state.c b/src/mesa/drivers/dri/i965/gen7_l3_state.c index 8c8f4169e7e..7044d5a8984 100644 --- a/src/mesa/drivers/dri/i965/gen7_l3_state.c +++ b/src/mesa/drivers/dri/i965/gen7_l3_state.c @@ -255,11 +255,16 @@ const struct brw_tracked_state gen7_l3_state = { .mesa = 0, .brw = BRW_NEW_BATCH | BRW_NEW_BLORP | + BRW_NEW_COMPUTE_PROGRAM | BRW_NEW_CS_PROG_DATA | + BRW_NEW_FRAGMENT_PROGRAM | BRW_NEW_FS_PROG_DATA | + BRW_NEW_GEOMETRY_PROGRAM | BRW_NEW_GS_PROG_DATA | + BRW_NEW_TESS_PROGRAMS | BRW_NEW_TCS_PROG_DATA | BRW_NEW_TES_PROG_DATA | + BRW_NEW_VERTEX_PROGRAM | BRW_NEW_VS_PROG_DATA, }, .emit = emit_l3_state -- 2.15.0 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>