<div dir="ltr">If you are referring to earlier discussion about having tizonia build problems then it was about disabling some extra CPU intensive features like the tizonia player which isn't needed here.<div>This was only required if you wanted to build from source instead of downloading it. Later Juan added an option to do the same <a href="https://github.com/tizonia/tizonia-openmax-il/commit/9ab5ecea12ee4dfe6ee058274c8e1a96d4d051e6">https://github.com/tizonia/tizonia-openmax-il/commit/9ab5ecea12ee4dfe6ee058274c8e1a96d4d051e6</a></div><div><br><div>Other than that any changes that were needed in the tizonia omxil code were pushed to the main branch before the project officially ended in august.</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 10:59 PM, Leo Liu <span dir="ltr"><<a href="mailto:leo.liu@amd.com" target="_blank">leo.liu@amd.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><span class="">
<p><br>
</p>
<br>
<div class="m_-8949310547104866527moz-cite-prefix">On 11/29/2017 12:23 PM, Christian König
wrote:<br>
</div>
<blockquote type="cite">
<div class="m_-8949310547104866527moz-cite-prefix">Am 29.11.2017 um 18:08 schrieb
Gurkirpal Singh:<br>
</div>
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Nov 29, 2017 at 3:20 PM,
Christian König <span dir="ltr"><<a href="mailto:ckoenig.leichtzumerken@gmail.com" target="_blank">ckoenig.leichtzumerken@gmail.<wbr>com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="m_-8949310547104866527gmail-HOEnZb">
<div class="m_-8949310547104866527gmail-h5">Am 29.11.2017 um 05:02 schrieb
Gurkirpal Singh:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> These are the
refactored commits related to the GSoC project
involving<br>
adding a st/omx state tracker using tizonia.<br>
There are still some parts of code that i didn't
refactor yet as<br>
explained below:<br>
1) I wasn't sure if it's okay to use #if-#else
declaratives for function<br>
declarations. For eg: One function accepts
omx_base_PortType and the other<br>
one vid_dec_PrivateType<br>
2) Because of the argument type differences there
is excessive amounts of<br>
#if-#else pairs will be needed<br>
So I decided to wait for review before making
those changes.<br>
</blockquote>
<br>
</div>
</div>
Looks really good to me and I think as well that we
should avoid excessive #if-#else pairs even if that
means we have a bit of code duplication.<br>
<br>
One question I have is why do you move the vl screen
helpers into the auxiliary code in the first patch and
not just keep it as common code under the st/omx
directory?</blockquote>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
I mean could make sense to use that somewhere else, but
we currently don't do this and your solution for the
rest of the code looks, e.g. the H264 decoder, looks
really nice to me. </blockquote>
<div>Before refactoring process both the state trackers
were in independet directories. During earlier
refactoring effort we decided to keep that directory
structure so it made sense to move</div>
<div>them to auxiliary code. After that I moved them both
under st/omx. Since there could be a chance of it being
useful out of st/omx, I left the decision to keep it or
move it back to st/omx</div>
<div>to the mailing list.</div>
</div>
</div>
</div>
</blockquote>
<br>
Fine with me.<br>
<br>
Leo any more comments on this? Otherwise I'm going to give it a
few more days on the list and push it if nobody objects.<br>
</blockquote></span>
I just had a quick look, it's pretty good to me as well.<br>
<br>
@Gurkirpal, do we still need some changes from Tizonia in order to
get it built/run?<span class="HOEnZb"><font color="#888888"><br>
<br>
Leo</font></span><span class=""><br>
<br>
<br>
<blockquote type="cite"> <br>
Regards,<br>
Christian.<br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
And the EGL image stuff really works? Well that is
extremely cool.<br>
</blockquote>
<div>I double checked the EGL feature with "top" and it
shows significantly less CPU usage compared to when not
using this feature.</div>
<div>Thanks to Julien for helping out a lot with this one
when he was mentoring me.</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
Regards,<br>
Christian.<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</blockquote>
<br>
</span></div>
</blockquote></div><br></div>