<div dir="ltr"><div><div>I'd roll 24 in with 25 personally. Either way, 24 and 25 are<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div>I'm going to try and get enough reviewed today that we can land this part.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 29, 2017 at 6:57 PM, Jose Maria Casanova Crespo <span dir="ltr"><<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Alejandro Piñeiro <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>><br>
<br>
It uses VK_KHR_get_physical_device_<wbr>properties2 functionality to expose<br>
if the extension is supported or not.<br>
<br>
v2: update due rebase against master (Alejandro)<br>
<br>
v3: (Jason Ekstrand)<br>
  - Move this patch up in VK_KHR_16bit_storage series enabling only<br>
   storageBuffer16BitAccess and uniformAndStorageBuffer16BitAc<wbr>cess.<br>
  - Only expose VK_KHR_16bit_storage on Gen8+<br>
<br>
Signed-off-by: Jose Maria Casanova Crespo <<a href="mailto:jmcasanova@igalia.com">jmcasanova@igalia.com</a>><br>
Signed-off-by: Alejandro Piñeiro <<a href="mailto:apinheiro@igalia.com">apinheiro@igalia.com</a>><br>
---<br>
 src/intel/vulkan/anv_device.c   | 13 +++++++++++++<br>
 src/intel/vulkan/anv_<wbr>extensions.py | 1 +<br>
 2 files changed, 14 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
index b5577ee61d..69a1f5a5f6 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -725,6 +725,19 @@ void anv_<wbr>GetPhysicalDeviceFeatures2KHR(<br>
     break;<br>
    }<br>
<br>
+Â Â Â case VK_STRUCTURE_TYPE_PHYSICAL_<wbr>DEVICE_16BIT_STORAGE_FEATURES_<wbr>KHR: {<br>
+Â Â Â Â Â ANV_FROM_HANDLE(anv_physical_<wbr>device, pdevice, physicalDevice);<br>
+<br>
+Â Â Â Â Â VkPhysicalDevice16BitStorageFe<wbr>aturesKHR *features =<br>
+Â Â Â Â Â Â (<wbr>VkPhysicalDevice16BitStorageFe<wbr>aturesKHR *)ext;<br>
+<br>
+Â Â Â Â Â features-><wbr>storageBuffer16BitAccess = pdevice->info.gen >= 8;<br>
+Â Â Â Â Â features-><wbr>uniformAndStorageBuffer16BitAc<wbr>cess = pdevice->info.gen >= 8;<br>
+Â Â Â Â Â features-><wbr>storagePushConstant16 = false;<br>
+Â Â Â Â Â features->storageInputOutput16 = false;<br>
+Â Â Â Â Â break;<br>
+Â Â Â }<br>
+<br>
    default:<br>
     anv_debug_ignored_stype(ext-><wbr>sType);<br>
     break;<br>
diff --git a/src/intel/vulkan/anv_<wbr>extensions.py b/src/intel/vulkan/anv_<wbr>extensions.py<br>
index b1e984b8cd..c49718dfd4 100644<br>
--- a/src/intel/vulkan/anv_<wbr>extensions.py<br>
+++ b/src/intel/vulkan/anv_<wbr>extensions.py<br>
@@ -51,6 +51,7 @@ class Extension:<br>
 # and dEQP-VK.api.info.device fail due to the duplicated strings.<br>
 EXTENSIONS = [<br>
   Extension('VK_ANDROID_native_<wbr>buffer',         5, 'ANDROID'),<br>
+  Extension('VK_KHR_16bit_<wbr>storage',           1, 'device->info.gen >= 8'),<br>
   Extension('VK_KHR_bind_<wbr>memory2',           1, True),<br>
   Extension('VK_KHR_dedicated_<wbr>allocation',       1, True),<br>
   Extension('VK_KHR_descriptor_<wbr>update_template',    1, True),<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>