<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Dec 4, 2017 at 9:07 PM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">On Mon, Dec 4, 2017 at 8:53 PM, Jordan Justen <span dir="ltr"><<a href="mailto:jordan.l.justen@intel.com" target="_blank">jordan.l.justen@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_3089421991220647095HOEnZb"><div class="m_3089421991220647095h5">On 2017-12-01 17:20:09, Jason Ekstrand wrote:<br>
> ---<br>
>  src/intel/vulkan/anv_device.c   | 1 +<br>
>  src/intel/vulkan/anv_pipeline.<wbr>c | 6 ++++++<br>
>  2 files changed, 7 insertions(+)<br>
><br>
> diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
> index 937efb9..43781bd 100644<br>
> --- a/src/intel/vulkan/anv_device.<wbr>c<br>
> +++ b/src/intel/vulkan/anv_device.<wbr>c<br>
> @@ -405,6 +405,7 @@ anv_physical_device_init(struc<wbr>t anv_physical_device *device,<br>
>     device->compiler->shader_debu<wbr>g_log = compiler_debug_log;<br>
>     device->compiler->shader_<wbr>perf_log = compiler_perf_log;<br>
>     device->compiler->supports_pu<wbr>ll_constants = false;<br>
> +   device->compiler->constant_bu<wbr>ffer_0_is_relative = true;<br>
><br>
>     isl_device_init(&device->isl_<wbr>dev, &device->info, swizzled);<br>
><br>
> diff --git a/src/intel/vulkan/anv_pipelin<wbr>e.c b/src/intel/vulkan/anv_pipelin<wbr>e.c<br>
> index 907b24a..3bb19ff 100644<br>
> --- a/src/intel/vulkan/anv_pipelin<wbr>e.c<br>
> +++ b/src/intel/vulkan/anv_pipelin<wbr>e.c<br>
> @@ -385,6 +385,9 @@ anv_pipeline_compile(struct anv_pipeline *pipeline,<br>
>                       struct brw_stage_prog_data *prog_data,<br>
>                       struct anv_pipeline_bind_map *map)<br>
>  {<br>
> +   const struct brw_compiler *compiler =<br>
> +      pipeline->device->instance->ph<wbr>ysicalDevice.compiler;<br>
> +<br>
>     nir_shader *nir = anv_shader_compile_to_nir(pipe<wbr>line, mem_ctx,<br>
>                                                 module, entrypoint, stage,<br>
>                                                 spec_info);<br>
> @@ -436,6 +439,9 @@ anv_pipeline_compile(struct anv_pipeline *pipeline,<br>
>     if (pipeline->layout)<br>
>        anv_nir_apply_pipeline_layout(<wbr>pipeline, nir, prog_data, map);<br>
><br>
> +   if (stage != MESA_SHADER_COMPUTE)<br>
> +      brw_nir_analyze_ubo_ranges(com<wbr>piler, nir, prog_data->ubo_ranges);<br>
<br>
</div></div>I guess the results of this analyze pass won't be used on Ivy Bridge?<br></blockquote><div><br></div></div></div><div>Yikes!  Those poor Ivy Bridge users were about to stop getting sane uniforms.  I'll add a devinfo->gen > 7 || devinfo->is_haswell to that.<br></div></div></div></div></blockquote><div><br></div><div>Actually... The nir_analize_ubo_ranges function already knows to bail for that so we're good.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Anyway, series Reviewed-by: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com" target="_blank">jordan.l.justen@intel.com</a>><span><br></span></blockquote><div><br></div></span><div>Thanks!<br></div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
>     assert(nir->num_uniforms == prog_data->nr_params * 4);<br>
><br>
>     return nir;<br>
> --<br>
> 2.5.0.400.gff86faf<br>
><br>
</span>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>