<div dir="ltr">I really like this in principal. I left comments on patches 2 and 3 which I think make things better. My comments on 2 are a bit on the bikeshed side, but I think reasonable. </div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Dec 8, 2017 at 2:54 AM, <<a href="mailto:kevin.rogovin@intel.com" target="_blank">kevin.rogovin@intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Kevin Rogovin <<a href="mailto:kevin.rogovin@intel.com">kevin.rogovin@intel.com</a>> This patch series adds a new debug option to pad each GEM BO allocated by the brw_bufmgr with random noise values which are then checked after each batchbuffer dispatch to the kernel. This can be quite valuable to find diffucult to track down heisenberg style bugs. A possible follow-up series would be to write to stderr (or another logging mechanism) if the OOB write is to a GEM BO that backs a GL buffer object; that features would be quite useful for application developers. Kevin Rogovin (3): intel/common:add debug flag for adding and checking padding on BO's i965: add noise padding to buffer object and function to check if noise is correct i965: if DEBUG_OUT_OF_BOUND_CHK is up, check that noise padding for each bo used in batchbuffer is correct src/intel/common/gen_debug.c | 1 + src/intel/common/gen_debug.h | 1 + src/mesa/drivers/dri/i965/brw_bufmgr.c | 68 ++++++++++++++++++++++++++- src/mesa/drivers/dri/i965/brw_bufmgr.h | 12 +++++ src/mesa/drivers/dri/i965/intel_batchbuffer.c | 15 ++++++ 5 files changed, 96 insertions(+), 1 deletion(-) -- 2.7.4 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>