<div dir="ltr"><div>What is the assertion? Just shutting off aligna1 ternaries seems a bit harsh.<br><br></div>--Jason<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 22, 2017 at 1:54 PM, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This reverts commit 9cd60fce9c22737000a8f8dc711141<wbr>f8a523fe75.<br>
Above commit caused 2000+ piglit tests to assert fail. Disabling<br>
the align1 mode on gen10 for now to avoid failures.<br>
<br>
Cc: Matt Turner <<a href="mailto:mattst88@gmail.com">mattst88@gmail.com</a>><br>
Cc: Rafael Antognolli <<a href="mailto:rafael.antognolli@intel.com">rafael.antognolli@intel.com</a>><br>
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
---<br>
---<br>
src/intel/compiler/brw_fs_<wbr>generator.cpp | 12 ++++--------<br>
1 file changed, 4 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs_<wbr>generator.cpp b/src/intel/compiler/brw_fs_<wbr>generator.cpp<br>
index 679c1f1916..6a3b2dcf8a 100644<br>
--- a/src/intel/compiler/brw_fs_<wbr>generator.cpp<br>
+++ b/src/intel/compiler/brw_fs_<wbr>generator.cpp<br>
@@ -1758,15 +1758,13 @@ fs_generator::generate_code(<wbr>const cfg_t *cfg, int dispatch_width)<br>
<br>
case BRW_OPCODE_MAD:<br>
assert(devinfo->gen >= 6);<br>
- if (devinfo->gen < 10)<br>
- brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
+ brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
brw_MAD(p, dst, src[0], src[1], src[2]);<br>
break;<br>
<br>
case BRW_OPCODE_LRP:<br>
assert(devinfo->gen >= 6);<br>
- if (devinfo->gen < 10)<br>
- brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
+ brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
brw_LRP(p, dst, src[0], src[1], src[2]);<br>
break;<br>
<br>
@@ -1864,8 +1862,7 @@ fs_generator::generate_code(<wbr>const cfg_t *cfg, int dispatch_width)<br>
<br>
case BRW_OPCODE_BFE:<br>
assert(devinfo->gen >= 7);<br>
- if (devinfo->gen < 10)<br>
- brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
+ brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
brw_BFE(p, dst, src[0], src[1], src[2]);<br>
break;<br>
<br>
@@ -1875,8 +1872,7 @@ fs_generator::generate_code(<wbr>const cfg_t *cfg, int dispatch_width)<br>
break;<br>
case BRW_OPCODE_BFI2:<br>
assert(devinfo->gen >= 7);<br>
- if (devinfo->gen < 10)<br>
- brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
+ brw_set_default_access_mode(p, BRW_ALIGN_16);<br>
brw_BFI2(p, dst, src[0], src[1], src[2]);<br>
break;<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.13.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>