<div dir="ltr">Thanks! I've pushed the last 3. I'll let the debate continue on 1/4. :-)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 28, 2017 at 9:25 AM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Reviewed-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><div class="HOEnZb"><div class="h5"><br>
<br>
On 27/12/17 20:58, Jason Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Previously, we were flagging the instruction state buffer for capture<br>
but not surface state or dynamic state. We want those captured too.<br>
---<br>
src/intel/vulkan/anv_device.c | 6 +++---<br>
1 file changed, 3 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
index 4638f31..680f5a7 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -1251,7 +1251,8 @@ VkResult anv_CreateDevice(<br>
goto fail_batch_bo_pool;<br>
/* For the state pools we explicitly disable 48bit. */<br>
- bo_flags = physical_device->has_exec_asyn<wbr>c ? EXEC_OBJECT_ASYNC : 0;<br>
+ bo_flags = (physical_device->has_exec_asy<wbr>nc ? EXEC_OBJECT_ASYNC : 0) |<br>
+ (physical_device->has_exec_cap<wbr>ture ? EXEC_OBJECT_CAPTURE : 0);<br>
result = anv_state_pool_init(&device->d<wbr>ynamic_state_pool, device, 16384,<br>
bo_flags);<br>
@@ -1259,8 +1260,7 @@ VkResult anv_CreateDevice(<br>
goto fail_bo_cache;<br>
result = anv_state_pool_init(&device->i<wbr>nstruction_state_pool, device, 16384,<br>
- bo_flags |<br>
- (physical_device->has_exec_cap<wbr>ture ? EXEC_OBJECT_CAPTURE : 0));<br>
+ bo_flags);<br>
if (result != VK_SUCCESS)<br>
goto fail_dynamic_state_pool;<br>
<br>
</blockquote>
<br>
<br>
</div></div></blockquote></div><br></div>