<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
Looks good.<br>
<br>
Reviewed-by: Neha Bhende<bhenden@vmware.com>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Brian Paul <brianp@vmware.com><br>
<b>Sent:</b> Thursday, December 28, 2017 8:19:24 AM<br>
<b>To:</b> mesa-dev@lists.freedesktop.org<br>
<b>Cc:</b> Charmaine Lee; Neha Bhende<br>
<b>Subject:</b> [PATCH] svga: check for null fs pointer in update_samplers()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">This can happen when there's no active fragment shader, such as<br>
when using transform feedback. This wasn't hit by any Piglit test<br>
but is hit by Daniel Rákos' Nature demo. VMware bug 2026189.<br>
---<br>
src/gallium/drivers/svga/svga_state_sampler.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/gallium/drivers/svga/svga_state_sampler.c b/src/gallium/drivers/svga/svga_state_sampler.c<br>
index 9bd0d53..11f36e3 100644<br>
--- a/src/gallium/drivers/svga/svga_state_sampler.c<br>
+++ b/src/gallium/drivers/svga/svga_state_sampler.c<br>
@@ -399,7 +399,7 @@ update_samplers(struct svga_context *svga, unsigned dirty )<br>
* for this texture unit, don't enable shadow compare in<br>
* the texture sampler state.<br>
*/<br>
- if (fs->fs_shadow_compare_units & (1 << i)) {<br>
+ if (fs && (fs->fs_shadow_compare_units & (1 << i))) {<br>
fs_shadow = true;<br>
}<br>
}<br>
-- <br>
1.9.1<br>
<br>
</div>
</span></font></div>
</body>
</html>