<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Dec 21, 2017, at 6:41 PM, Andres Rodriguez <<a href="mailto:andresx7@gmail.com" class="">andresx7@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="">Rename fences -> semaphores in preparation for upgrading fence<br class="">
functionality.<br class="">
<br class="">
This series renames the following symbols:<br class="">
- pipe_fence_handle -> pipe_semaphore_handle<br class="">
- fence_server_sync -> semaphore_server_sync<br class="">
- create_fence_fd -> create_semaphore_fd<br class="">
- fence_reference -> semaphore_reference<br class="">
- fence_finish -> semaphore_finish<br class="">
- fence_get_fd -> semaphore_get_fd<br class="">
- PIPE_FLUSH_FENCE_FD -> PIPE_FLUSH_SEMAPHORE_FD<br class="">
- PIPE_CAP_NATIVE_FENCE_FD -> PIPE_CAP_NATIVE_SEMAPHORE_FD<br class="">
<br class="">
This patch does not introduce any functionality changes.<br class="">
</div>
</div>
</blockquote>
<div><br class="">
</div>
<span style="font-family: Menlo-Regular; font-size: 11px;" class="">Hi Andres. This rename leaves the drivers in a weird mixed nomenclature between</span><br style="font-family: Menlo-Regular; font-size: 11px;" class="">
<span style="font-family: Menlo-Regular; font-size: 11px;" class="">fence and semaphore. Is there a plan to clean this up?</span><br class="">
<div><br class="">
</div>
<div>Example, pulled from lp_screen.c:</div>
<div><br class="">
</div>
<div>
<blockquote type="cite" style="font-family: Menlo-Regular; font-size: 11px;" class="">
* Fence reference counting.<br class="">
*/<br class="">
static void<br class="">
-llvmpipe_fence_reference(struct pipe_screen *screen,<br class="">
- struct pipe_fence_handle **ptr,<br class="">
- struct pipe_fence_handle *fence)<br class="">
+llvmpipe_semaphore_reference(struct pipe_screen *screen,<br class="">
+ struct pipe_semaphore_handle **ptr,<br class="">
+ struct pipe_semaphore_handle *fence)<br class="">
{<br class="">
struct lp_fence **old = (struct lp_fence **) ptr;<br class="">
struct lp_fence *f = (struct lp_fence *) fence;<br class="">
<br class="">
- lp_fence_reference(old, f);<br class="">
+ lp_semaphore_reference(old, f);<br class="">
}<br class="">
</blockquote>
<br style="font-family: Menlo-Regular; font-size: 11px;" class="">
<span style="font-family: Menlo-Regular; font-size: 11px;" class="">We're casting semaphore handles to lp_fence pointers and passing</span><br style="font-family: Menlo-Regular; font-size: 11px;" class="">
<span style="font-family: Menlo-Regular; font-size: 11px;" class="">fences into lp_semaphore_reference. A confusing mix of terminology.</span></div>
</div>
<br class="">
</body>
</html>