<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jan 10, 2018 at 1:35 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">"The maxDescriptorSet* limit is n times the corresponding<br>
maxPerStageDescriptor* limit, where n is the number of shader stages<br>
supported by the VkPhysicalDevice. If all shader stages are supported,<br>
n = 6 (vertex, tessellation control, tessellation evaluation,<br>
geometry, fragment, compute)."<br>
<br>
Fixes:<br>
<br>
dEQP-VK.api.info.device.<wbr>properties<br>
<br>
Signed-off-by: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
---<br>
<br>
Fixes CL#2078.<br>
<br>
Jason, I don't now if is there any HW limitation for these.<br></blockquote><div><br></div><div>Nope, this should be fine.</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
src/intel/vulkan/anv_device.c | 10 +++++-----<br>
1 file changed, 5 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
index 680f5a752d6..90fdda66c5b 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -797,13 +797,13 @@ void anv_<wbr>GetPhysicalDeviceProperties(<br>
.<wbr>maxPerStageDescriptorStorageIm<wbr>ages = 64,<br>
.<wbr>maxPerStageDescriptorInputAtta<wbr>chments = 64,<br>
.maxPerStageResources = 250,<br>
- .maxDescriptorSetSamplers = 256,<br>
- .<wbr>maxDescriptorSetUniformBuffers = 256,<br>
+ .maxDescriptorSetSamplers = 6 * max_samplers, /* number of stages * maxPerStageDescriptorSamplers */<br>
+ .<wbr>maxDescriptorSetUniformBuffers = 6 * 64, /* number of stages * maxPerStageDescriptorUniformBu<wbr>ffers */<br>
.<wbr>maxDescriptorSetUniformBuffers<wbr>Dynamic = MAX_DYNAMIC_BUFFERS / 2,<br>
- .<wbr>maxDescriptorSetStorageBuffers = 256,<br>
+ .<wbr>maxDescriptorSetStorageBuffers = 6 * 64, /* number of stages * maxPerStageDescriptorStorageBu<wbr>ffers */<br>
.<wbr>maxDescriptorSetStorageBuffers<wbr>Dynamic = MAX_DYNAMIC_BUFFERS / 2,<br>
- .maxDescriptorSetSampledImages = 256,<br>
- .maxDescriptorSetStorageImages = 256,<br>
+ .maxDescriptorSetSampledImages = 6 * max_samplers, /* number of stages * maxPerStageDescriptorSampledIm<wbr>ages */<br>
+ .maxDescriptorSetStorageImages = 6 * 64, /* number of stages * maxPerStageDescriptorStorageIm<wbr>ages */<br>
.<wbr>maxDescriptorSetInputAttachmen<wbr>ts = 256,<br>
.maxVertexInputAttributes = MAX_VBS,<br>
.maxVertexInputBindings = MAX_VBS,<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.1<br>
<br>
</font></span></blockquote></div><br></div></div>